Skip to content

Update spack-stack-dev from spack develop as of 2024/10/31 - #1363

Merged
climbfuji merged 19 commits into
JCSDA:developfrom
climbfuji:feature/update_from_spack_dev_20241031
Nov 14, 2024
Merged

Update spack-stack-dev from spack develop as of 2024/10/31#1363
climbfuji merged 19 commits into
JCSDA:developfrom
climbfuji:feature/update_from_spack_dev_20241031

Conversation

@climbfuji

@climbfuji climbfuji commented Nov 4, 2024

Copy link
Copy Markdown
Collaborator

Summary

  • Update submodule pointer for spack for the changes in Update spack-stack-dev from spack develop as of 2024/10/31 spack#482 (update from spack develop as of 2024/10/31)
  • Make macOS CI test look like the UBuntu CI tests (split into two steps: first create buildcache environment, then install test environment from the buildcache)
  • Remove deprecated -a flag from spack buildcache push for all GitHub actions workflows
  • Add +classic-names to the intel-oneapi-mpi external package definition in GitHub actions. May need to do the same for each of the preconfigured sites when using icc+icpc+ifort. Without +classic-names, it works for icx+icpx+ifort and for ``icx+icpx`+`ifx`.
  • Updates to configs/common/packages.yaml to remove deprecated variants and pin certain packages to avoid duplicate packages 
  • Update tier2 site config for blackpeark and bump PrgEnv for Narwhal
  • Bug fix: gsi-env does not depend on esmf, for some reason the concretizer didn't realize this until now

Testing

Describe the testing done for this PR.

  • Built NEPTUNE standalone environment on Blackpearl with gcc@13.3.0, compiled NEPTUNE with it
  • Built NEPTUNE standalone environment on Blackpearl with oneapi@2024.2.1, compiled NEPTUNE with it
  • Built unified environment on Blackpearl with gcc@13.3.0
  • @srherbener tested JEDI on macOS and got the same successes/failures as with the current spack-stack develop branch (thanks for testing!)
  • CI
  • Tested UE concretization on Acorn (@AlexanderRichert-NOAA)
  • Tested installing NCO stack on Acorn (@AlexanderRichert-NOAA)

Applications affected

Potentially all

Systems affected

None directly

Dependencies

Issue(s) addressed

Resolves #1181

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

@climbfuji climbfuji self-assigned this Nov 4, 2024

@srherbener srherbener left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks for all the work to get our spack fork sync'd up!

@AlexanderRichert-NOAA

Copy link
Copy Markdown
Collaborator

This looks really good. The only issue I encountered in testing is that I'll need to pin the GDAL version in the NCO template. Is it alright if I add this here, or would you prefer it in a followup PR?

@climbfuji

Copy link
Copy Markdown
Collaborator Author

This looks really good. The only issue I encountered in testing is that I'll need to pin the GDAL version in the NCO template. Is it alright if I add this here, or would you prefer it in a followup PR?

Thanks for testing! Feel free to push to this PR.

@climbfuji

Copy link
Copy Markdown
Collaborator Author

@AlexanderRichert-NOAA I'll merge the spack PR for the update from spack dev and update the submodule pointer here, but will wait for your gdal nco update before merging this.

@AlexanderRichert-NOAA

Copy link
Copy Markdown
Collaborator

Done, thanks

@climbfuji
climbfuji merged commit 9fbd7bb into JCSDA:develop Nov 14, 2024
@climbfuji
climbfuji deleted the feature/update_from_spack_dev_20241031 branch November 14, 2024 11:46
climbfuji added a commit that referenced this pull request Nov 15, 2024
…ntainer builds for gcc and clang, and work towards fixing intel (#1381)

This PR is a follow up to the update from spack develop in #1363. It removes the external gmake packages so that the new requirement for gmake to be one of 4.2.1 or 4.4.1 can be honored.
AlexanderRichert-NOAA added a commit that referenced this pull request Nov 20, 2024
…low-up-mpiifx-mpiifort-site-configs

Follow-up to #1363 (update from spack dev 20241031): set correct mpiifx/mpiifort in MPI meta module, update Intel MPI in site configs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

Update spack to v0.22.1 (or a newer release or develop, September 2024)

3 participants