Skip to content

Follow-up to #1363 (update from spack dev 20241031): set correct mpiifx/mpiifort in MPI meta module, update Intel MPI in site configs - #1378

Merged
AlexanderRichert-NOAA merged 25 commits into
JCSDA:developfrom
climbfuji:feature/spst-upd-20241031-follow-up-mpiifx-mpiifort-site-configs
Nov 20, 2024
Merged

Follow-up to #1363 (update from spack dev 20241031): set correct mpiifx/mpiifort in MPI meta module, update Intel MPI in site configs#1378
AlexanderRichert-NOAA merged 25 commits into
JCSDA:developfrom
climbfuji:feature/spst-upd-20241031-follow-up-mpiifx-mpiifort-site-configs

Conversation

@climbfuji

@climbfuji climbfuji commented Nov 12, 2024

Copy link
Copy Markdown
Collaborator

Summary

  1. For all site configs that use the Intel classic compilers with Intel's MPI (intel-oneapi-mpi%intel), set variant +classic-names in the external package definition - this makes spack use icc, icpc, ifort. For intel-oneapi-mpi%oneapi (icx, icpx, ifortorifx`), this isn't needed.
  2. Add CI workflow on Ubuntu with icx, icpx, ifx. At some point later, the mixed setup icx, icpx, ifort will go away, but for now, we need both.
  3. Update setup-meta-modules extension: save the compiler config from the preferred compiler (last entry in the list of compilers) so that it is available for creating the MPI meta module. This is needed so that we can set the correct MPI compiler wrapper commands (e.g. mpicc vs. mpiicc vs. mpiicx).

Testing

  • Locally on my laptop with %oneapi (icx, icpx, ifx)
  • CI (checked that all Ubuntu CI runs had the correct MPI compiler wrappers in the MPI meta modules for the given compiler)

Applications affected

None

Systems affected

None really

Dependencies

n/a

Issue(s) addressed

Working towards #912

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

….1, and remove noavx512 variant for openblas
…ormation from preferred compiler to set correct MPI compiler wrapper command in MPI meta module (especially for Intel oneAPI)
@climbfuji climbfuji self-assigned this Nov 12, 2024
Comment thread .github/workflows/ubuntu-ci-x86_64-oneapi.yaml Outdated
@climbfuji
climbfuji marked this pull request as ready for review November 14, 2024 19:09
@AlexanderRichert-NOAA
AlexanderRichert-NOAA merged commit 33dc2d5 into JCSDA:develop Nov 20, 2024
@climbfuji
climbfuji deleted the feature/spst-upd-20241031-follow-up-mpiifx-mpiifort-site-configs branch March 24, 2026 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

2 participants