Follow-up to #1363 (update from spack dev 20241031): set correct mpiifx/mpiifort in MPI meta module, update Intel MPI in site configs - #1378
Merged
AlexanderRichert-NOAA merged 25 commits intoNov 20, 2024
Conversation
….1, and remove noavx512 variant for openblas
…eature/update_from_spack_dev_20241031
…ci-x86_64-intel.yaml
…eature/update_from_spack_dev_20241031
…figs that need it
…ormation from preferred compiler to set correct MPI compiler wrapper command in MPI meta module (especially for Intel oneAPI)
…i-x86_64-oneapi-ifx.yaml
…eature/update_from_spack_dev_20241031
…ub.com/climbfuji/spack-stack into feature/spst-upd-20241031-follow-up-mpiifx-mpiifort-site-configs
…eature/spst-upd-20241031-follow-up-mpiifx-mpiifort-site-configs
climbfuji
commented
Nov 14, 2024
climbfuji
marked this pull request as ready for review
November 14, 2024 19:09
climbfuji
requested review from
AlexanderRichert-NOAA,
RatkoVasic-NOAA,
srherbener and
stiggy87
November 14, 2024 19:09
4 tasks
…x-mpiifort-site-configs
This was referenced Nov 18, 2024
AlexanderRichert-NOAA
approved these changes
Nov 20, 2024
climbfuji
deleted the
feature/spst-upd-20241031-follow-up-mpiifx-mpiifort-site-configs
branch
March 24, 2026 22:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
intel-oneapi-mpi%intel), set variant+classic-namesin the external package definition - this makes spack useicc,icpc,ifort. For intel-oneapi-mpi%oneapi(icx,icpx,ifortorifx`), this isn't needed.icx,icpx,ifx. At some point later, the mixed setupicx,icpx,ifortwill go away, but for now, we need both.setup-meta-modulesextension: save the compiler config from the preferred compiler (last entry in the list of compilers) so that it is available for creating the MPI meta module. This is needed so that we can set the correct MPI compiler wrapper commands (e.g.mpiccvs.mpiiccvs.mpiicx).Testing
%oneapi(icx,icpx,ifx)Applications affected
None
Systems affected
None really
Dependencies
n/a
Issue(s) addressed
Working towards #912
Checklist
All dependency PRs/issues have been resolved and this PR can be merged.