Update feature/ufs_dom from develop 2024-03-08#1024
Merged
travissluka merged 4 commits intofeature/ufs_domfrom Mar 8, 2024
Merged
Update feature/ufs_dom from develop 2024-03-08#1024travissluka merged 4 commits intofeature/ufs_domfrom
travissluka merged 4 commits intofeature/ufs_domfrom
Conversation
* deprecate horizfilt/vertconv * remove old tests * remove 3dvar_godas * remove SocaError * remove horizfilt * remove vertconv * WIP * add explicit_diffusion sqrt multiply * fix more tests * update tests * increase tolerances
Contributor
|
what was happening with the checkpoint test? |
Contributor
Author
It complained that the dependency for the test target couldn't be found |
Contributor
hmm, oh well. |
Contributor
Author
|
Good news is that ufs-bundle CI passed, so I'll open this up for review |
Contributor
Author
|
Thanks @travissluka ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update feature/ufs_dom from develop 2024-03-08
I had to resolve a few conflicts and make a few changes, most notably:
Issue(s) addressed
ufs-bundle ng-godas currently broken
Testing
Dependencies
n/a