Merged
Conversation
Contributor
Author
|
over 3,000 lines of code deleted, woo 🎉 |
Contributor
Author
|
GPT: "A JEDI computer programmer about to delete thousands of lines of code. Sitting at his computer, laughing, surrounded by an apocalyptic ocean and sea-ice scene outside" |
travissluka
added a commit
that referenced
this pull request
Mar 8, 2024
* Remove old static B code (#1020) * deprecate horizfilt/vertconv * remove old tests * remove 3dvar_godas * remove SocaError * remove horizfilt * remove vertconv * WIP * add explicit_diffusion sqrt multiply * fix more tests * update tests * increase tolerances * Remove MOM_restart_CS from src/soca/Model/ufs/soca_mom6.F90 * Comment out checkpoint test in test/CMakeLists.txt --------- Co-authored-by: Travis Sluka <tsluka@ucar.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes
VertConv,HorizFilt,andSocaError, as these have been replaced byEXPLICIT_DIFFUSIONsaber central block.What was changed
VertConvclass and remove from ctestsHorizFiltclass and remove from ctestsSocaErrorclass (empty stubs are still needed fortraits.h) and replace withEXPLICIT_DIFFUSIONin the ctestsEXPLICIT_DIFFUSION(multiplying gaussian noise by the square root of the diffusion operator), for theensperttestEXPLICIT_DIFFUSIONfor correlation andBUMP_NICASfor localization.data_output/directory is created for each ctest working directory to put its output. This way, I can easily grep thetestinput/config files to see what the inputs for a ctest are./data_generated/...