Skip to content

fix to using zero tolerances #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PatNichols wants to merge 1 commit into from
Closed

fix to using zero tolerances #1066

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ endforeach(FILENAME)
# iodaconv_comp.sh test.
#
# For a converter that is generating new data, use a non-zero tolerance.
set(IODA_CONV_COMP_TOL_ZERO "0.0")
set(IODA_CONV_COMP_TOL_ZERO "1.e-7")
Copy link
Copy Markdown
Collaborator

@BenjaminRuston BenjaminRuston Sep 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PatNichols do not think this is the way to go... this definition should remain zero

my approach was to change those tests to use the other tolerance:

IODA_CONV_COMP_TOL please see my PR #1064

set(IODA_CONV_COMP_TOL "0.5e-4")

# The ioda-engines CMake configuration has set the file target _ioda_python to
Expand Down