Closed
Conversation
PatNichols
requested review from
BenjaminRuston,
fabiolrdiniz and
gthompsnJCSDA
Contributor
fabiolrdiniz
left a comment
fabiolrdiniz
left a comment
There was a problem hiding this comment.
Thanks for adding me here, @PatNichols. I'm a little bit confused. Why don't use the IODA_CONV_COMP_TOL for the comparison of the tests that are failing? It's already defined in the code (see line 341).
| # | ||
| # For a converter that is generating new data, use a non-zero tolerance. | ||
| set(IODA_CONV_COMP_TOL_ZERO "0.0") | ||
| set(IODA_CONV_COMP_TOL_ZERO "1.e-7") |
Collaborator
There was a problem hiding this comment.
@PatNichols do not think this is the way to go... this definition should remain zero
my approach was to change those tests to use the other tolerance:
IODA_CONV_COMP_TOL please see my PR #1064
Collaborator
|
this is redundant functionally with #1064 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some of the ctests are failing due to the tolerances being set to zero. This PR will hopefully fix this by assigning a small but non-zero tolerance from these tests.
Issue(s) addressed
-fixes #1063
Acceptance Criteria (Definition of Done)
ctests that should fail will hopefully fail but those with small errors due to compiler differences will pass.
Dependencies
None