Conversation
gthompsnJCSDA
requested review from
BenjaminRuston,
cmgas,
fabiolrdiniz and
shlyaeva
cmgas
approved these changes
Aug 9, 2023
Collaborator
cmgas
left a comment
cmgas
left a comment
There was a problem hiding this comment.
This repaired the tests for me! Thank you very much
fabiolrdiniz
approved these changes
Aug 9, 2023
Contributor
fabiolrdiniz
left a comment
fabiolrdiniz
left a comment
There was a problem hiding this comment.
Thanks, @gthompsnJCSDA!
Contributor
|
Thank you @gthompsnJCSDA ! |
climbfuji
added a commit
that referenced
this pull request
Aug 30, 2023
…82) * companion PR for fv3-jedi vertinterp sprint branch (#73) * upgrade testinput for trace gas * ad qa * Update version (#76) * test file for stretched grid testing (#74) * test file for stretched grid testing * cleaner * replace with the correct file * Add restart files with fractional grid and obs data for land DA. (#75) * Add restart files with fractional grid and obs data for land DA. * Add restart files with fractional grid and obs data for land DA. * Remove the old data files. * Replace the ghcn snow depth data. * Replace SMAP soil moisture data for the new date. * [Bugfix] update sensor scan position (from float to int) per changes in UFO, IODA, etc. (#79) * update sensorScanPosition from float to int * update sensorScanPosition from float to int --------- Co-authored-by: gthompsnJCSDA <gthompsn@ucar.edu> --------- Co-authored-by: Jérôme Barré <barre@ucar.edu> Co-authored-by: Yannick Trémolet <30638944+ytremolet@users.noreply.github.com> Co-authored-by: Maryam Abdi <maryamao@ucar.edu> Co-authored-by: Jiarui Dong <Jiarui.Dong@noaa.gov> Co-authored-by: Greg Thompson <63315545+gthompsnJCSDA@users.noreply.github.com> Co-authored-by: gthompsnJCSDA <gthompsn@ucar.edu>
climbfuji
added a commit
that referenced
this pull request
Oct 20, 2023
* Update testinput_tier_1/inputs/ufs_c48_warmstart/fd_nems.yaml for ufs-weather-model update of 2023/07/17 * Update feature/ufs_dom_update_ufswm_20230717 from develop 2023/08/30 (#82) * companion PR for fv3-jedi vertinterp sprint branch (#73) * upgrade testinput for trace gas * ad qa * Update version (#76) * test file for stretched grid testing (#74) * test file for stretched grid testing * cleaner * replace with the correct file * Add restart files with fractional grid and obs data for land DA. (#75) * Add restart files with fractional grid and obs data for land DA. * Add restart files with fractional grid and obs data for land DA. * Remove the old data files. * Replace the ghcn snow depth data. * Replace SMAP soil moisture data for the new date. * [Bugfix] update sensor scan position (from float to int) per changes in UFO, IODA, etc. (#79) * update sensorScanPosition from float to int * update sensorScanPosition from float to int --------- Co-authored-by: gthompsnJCSDA <gthompsn@ucar.edu> --------- Co-authored-by: Jérôme Barré <barre@ucar.edu> Co-authored-by: Yannick Trémolet <30638944+ytremolet@users.noreply.github.com> Co-authored-by: Maryam Abdi <maryamao@ucar.edu> Co-authored-by: Jiarui Dong <Jiarui.Dong@noaa.gov> Co-authored-by: Greg Thompson <63315545+gthompsnJCSDA@users.noreply.github.com> Co-authored-by: gthompsnJCSDA <gthompsn@ucar.edu> --------- Co-authored-by: Jérôme Barré <barre@ucar.edu> Co-authored-by: Yannick Trémolet <30638944+ytremolet@users.noreply.github.com> Co-authored-by: Maryam Abdi <maryamao@ucar.edu> Co-authored-by: Jiarui Dong <Jiarui.Dong@noaa.gov> Co-authored-by: Greg Thompson <63315545+gthompsnJCSDA@users.noreply.github.com> Co-authored-by: gthompsnJCSDA <gthompsn@ucar.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A "hot fix" for failing fv3-jedi ctest failures because some obs files were not updated for variable
sensorScanPositionfrom floating point to integer per changes to codes in ufo, ioda-converters, ufo-data, etc.Issue(s) addressed
A specific issue was not created, this is a quick hot fix.
Dependencies
None
Impact
None expected.