Skip to content

release/skylab-v4: Update version to 1.6.0 in CMakeLists.txt #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
climbfuji merged 1 commit into from
Mar 23, 2023
Merged

release/skylab-v4: Update version to 1.6.0 in CMakeLists.txt #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@

cmake_minimum_required( VERSION 3.3.2 FATAL_ERROR )

project( fv3_jedi_data VERSION 1.4.0 DESCRIPTION "FV3-JEDI Test Files" )
project( fv3_jedi_data VERSION 1.5.0 DESCRIPTION "FV3-JEDI Test Files" )
Copy link
Collaborator

@fmahebert fmahebert Mar 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[general question, not a change request, not related to this PR] What meaning are we trying to convey with these integers? Do we have criteria for mapping code changes to tiers of the version number? As I understand it, semantic versioning traditionally correlates to API/ABI compatibility breaking changes, but we never even talk about this...

Copy link
Contributor Author

@climbfuji climbfuji Mar 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are 100% correct. We should be doing a better job with this in general. In many cases, though, it's still ok what we do. The patch version change obviously refers to bug/hot fixes. The increase in the minor version number indicates no API changes, modest updates. A major version number indicates an overhaul, a significant API change, ...