Skip to content

release/skylab-v4: Update version to 1.6.0 in CMakeLists.txt#66

Merged
climbfuji merged 1 commit intorelease/skylab-v4from
feature/release_skylab_v4_update_version
Mar 23, 2023
Merged

release/skylab-v4: Update version to 1.6.0 in CMakeLists.txt#66
climbfuji merged 1 commit intorelease/skylab-v4from
feature/release_skylab_v4_update_version

Conversation

@climbfuji
Copy link
Contributor

Description

See title

@climbfuji climbfuji requested a review from fmahebert March 23, 2023 01:10
cmake_minimum_required( VERSION 3.3.2 FATAL_ERROR )

project( fv3_jedi_data VERSION 1.4.0 DESCRIPTION "FV3-JEDI Test Files" )
project( fv3_jedi_data VERSION 1.5.0 DESCRIPTION "FV3-JEDI Test Files" )
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[general question, not a change request, not related to this PR] What meaning are we trying to convey with these integers? Do we have criteria for mapping code changes to tiers of the version number? As I understand it, semantic versioning traditionally correlates to API/ABI compatibility breaking changes, but we never even talk about this...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are 100% correct. We should be doing a better job with this in general. In many cases, though, it's still ok what we do. The patch version change obviously refers to bug/hot fixes. The increase in the minor version number indicates no API changes, modest updates. A major version number indicates an overhaul, a significant API change, ...

@climbfuji climbfuji merged commit 55197f7 into release/skylab-v4 Mar 23, 2023
@climbfuji climbfuji deleted the feature/release_skylab_v4_update_version branch March 23, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants