Skip to content

sss addesd to sfc_data bkg files#35

Merged
shlyaeva merged 1 commit intodevelopfrom
feature/sss_gfs_c12
Jun 9, 2022
Merged

sss addesd to sfc_data bkg files#35
shlyaeva merged 1 commit intodevelopfrom
feature/sss_gfs_c12

Conversation

@HamidehGMAO
Copy link
Contributor

@HamidehGMAO HamidehGMAO commented Jun 8, 2022

Description

I have added sss to the gfs_c12 bkg data for the 2020121500. Previously I had added sss using the World Ocean Atlas (WOA) data "https://www.ncei.noaa.gov/products/world-ocean-atlas", for the 20180415. As there is not any data available for after 2018 in WOA website, I have used the sss data from SMAP sss retrievals here "https://podaac.jpl.nasa.gov/dataset/SMAP_JPL_L3_SSS_CAP_MONTHLY_V5?ids=&values=&search=SMAP%20JPL%20V5%20L3&provider=PODAAC"

Issue(s) addressed

Add SSS field to background files #417

@HamidehGMAO HamidehGMAO self-assigned this Jun 8, 2022
@HamidehGMAO HamidehGMAO requested a review from cmgas June 8, 2022 01:38
@cmgas
Copy link
Collaborator

cmgas commented Jun 8, 2022

Do you have a corresponding PR in fv3-jedi to add sss to the tests?

@HamidehGMAO
Copy link
Contributor Author

Do you have a corresponding PR in fv3-jedi to add sss to the tests?

@cmgas I just made this PR https://github.com/JCSDA-internal/fv3-jedi/pull/503, but I couldn't find the test associated to the hofx_fv3-gfs. when I run the ctest in fv3-jedi just tier1 tests run, should I do something to run tier2?

@cmgas
Copy link
Collaborator

cmgas commented Jun 9, 2022

Do you have a corresponding PR in fv3-jedi to add sss to the tests?

@cmgas I just made this PR JCSDA-internal/fv3-jedi#503, but I couldn't find the test associated to the hofx_fv3-gfs. when I run the ctest in fv3-jedi just tier1 tests run, should I do something to run tier2?

You need to build your fv3-jedi repo with tier2 tests enabled. I can do that for you today!

@HamidehGMAO
Copy link
Contributor Author

@cmgas Thanks. If you can point me to the instruction, or tell me the steps I will do that. Thanks

@cmgas
Copy link
Collaborator

cmgas commented Jun 9, 2022

@cmgas Thanks. If you can point me to the instruction, or tell me the steps I will do that. Thanks

You need to export the environment variable FV3JEDI_TEST_TIER=2. I'm not sure if re-running ecbuild is necessary, then you run make again.

The whole group of tier2 tests is pretty long to run but you shouldn't need to run the tier2 bump tests for hofx.

@HamidehGMAO
Copy link
Contributor Author

Thanks for the instruction. I'll take a look.

@cmgas
Copy link
Collaborator

cmgas commented Jun 9, 2022

I see that the variable sss doesn't have a checksum associated with it, when the other ones have it. Does is matter much?

	double f10m(Time, zaxis_1, yaxis_1, xaxis_1) ;
		f10m:long_name = "f10m" ;
		f10m:units = "none" ;
		f10m:checksum = "C9624F96E8056332" ;

	double sss(Time, zaxis_1, yaxis_1, xaxis_1) ;
		sss:long_name = "sss" ;
		sss:units = "psu" ;

@HamidehGMAO
Copy link
Contributor Author

Yeah! I don't think it does matter. Actually I don't know how the checksum value is generated for the other variables. I remember last time I added the sss to the bkg we decided to just ignore it.

Copy link
Collaborator

@cmgas cmgas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for re-adding these

@shlyaeva shlyaeva merged commit 77a2a61 into develop Jun 9, 2022
@shlyaeva shlyaeva deleted the feature/sss_gfs_c12 branch June 9, 2022 23:42
climbfuji added a commit that referenced this pull request Jul 6, 2022
…evelop_20220705

* Bump release number (#8)

* Added a copy of aircraft_obs_2018041500_m.nc4 with air_temperature renamed to renamed_air_temperature. (#9)
* Added two single ob files (#11)
* Add files with bias correction related data (#13)
* Add new ghcn snow depth data for using totalSnowDepth as obs name. (#15)
* Initial checking for RRFS configuration and sample files

* test aircraft data used with RRFS background

* substitute full RAP domain at 13km to CONUS-only 25km

* needed file renaming to include tile1

* oh well, sfc_data file should not have tile in the name, ugh

* Remove unused observation files from fv3-jedi-data (#20)

* Remove unused observation files from fv3-jedi-data

* restore file sst

* Restore more files

* Update the letkf_snow test case - data files. (#17)

* testing git-lfs.

* Changed background files from 12 to 18 UTC.

* Copy of (corrupted) feature/snowOI_test branch

* update ghcnd snow obs for test

* remove old ghcnd obs

Co-authored-by: Andrew Fox <afox@cheyenne4.cheyenne.ucar.edu>
Co-authored-by: Andrew Fox <afox@cheyenne6.cheyenne.ucar.edu>
Co-authored-by: amfox37 <amfox37@gmail.com>
Co-authored-by: Francois Hebert <hebert@ucar.edu>

* AERONET AOD and AAOD obs  (#21)

* add aeronet obs

* rename

* rename

* add aaod obs

* reverse add aaod to this branch

* aaod

* fix aaod

* fix errors

Co-authored-by: Anna Shlyaeva <annash@ucar.edu>

* Feature/avkvcoord (#22)

* update input data for tropomi_no2 test (lam_cmaq)

* update testinput data for tropomi no2

* add geos cf bkg C12 file (#29)

* Switch to 127 levels in gfs model (#26)

* Part of the obs files needed

* Remove unused observation files from fv3-jedi-data

* Remove 2018 files

* restore file sst

* New files gfs

* Add gnssro data

* Add geos crtm files

* Remove 2018 files geos c12

* oConverted c12 geos ensemble files

* rename files

* Update files to inclue ql

* Re add missing files

* Re add aero obs files

* remove files, i am not sure why i put them back

* Rename files

* Remove big aircraft file

* Add Dan's obs files

* Update gfs member files to include all variables

* Rename file error

* Put back geos aod obs file

* Add all variables to ens members

* Add amsr2 file

* Remove useless files and update gitignore

* Update the GSI static B coefficient file (#30)

* add Teppei's more recent file

* sync coeff file with saber

* rename file to 127 levels

* update levels in gsi b file to 127

Co-authored-by: danholdaway <danholdaway@users.noreply.github.com>

* Feature/ufs history io (#28)

* Add C12 cubed sphere history file for unit tests
* Update gfs history file

* Adding viirs_bias.nc  file for aerosol bias correction DA. (#31)

* data for GEOS-CF 3D Var tests (#32)

* add geoscf bkg files

* add tropomi no2 file

* update testintput files for geos hofx

* add stddev file for geos cf static b

* add stdev file but one should be removed after cleaning

* stddev file for geos-cf test

* update stddev file

* update stddev test again

* update tropomi data

* fix obs file

* update obs input to what it was

* Reformatted VIIRS AOD variables into 2D (nlocs X nchans) for V2 compatibility. (#33)

* Use lowercase names in all GEOS files (#34)

Co-authored-by: danholdaway <danholdaway@users.noreply.github.com>

* sss obs added (#37)

* sss addesd to sfc_data bkg files (#35)

* Bump version in CMakeLists.txt to 1.2.0 (#38)

Co-authored-by: Mark Miesch <miesch@ucar.edu>
Co-authored-by: Wojciech Śmigaj <wojciech.smigaj@metoffice.gov.uk>
Co-authored-by: frolovsa <55715838+frolovsa@users.noreply.github.com>
Co-authored-by: Anna Shlyaeva <shlyaeva@gmail.com>
Co-authored-by: Jiarui Dong <Jiarui.Dong@noaa.gov>
Co-authored-by: gthompsnJCSDA <gthompsn@ucar.edu>
Co-authored-by: Clementine Gas <43183478+cmgas@users.noreply.github.com>
Co-authored-by: Francois Hebert <hebert@ucar.edu>
Co-authored-by: ClaraDraper-NOAA <33430543+ClaraDraper-NOAA@users.noreply.github.com>
Co-authored-by: Andrew Fox <afox@cheyenne4.cheyenne.ucar.edu>
Co-authored-by: Andrew Fox <afox@cheyenne6.cheyenne.ucar.edu>
Co-authored-by: amfox37 <amfox37@gmail.com>
Co-authored-by: Mariusz Pagowski <mariusz.pagowski@noaa.gov>
Co-authored-by: Anna Shlyaeva <annash@ucar.edu>
Co-authored-by: Jérôme Barré <barre@ucar.edu>
Co-authored-by: Dan Holdaway <27729500+danholdaway@users.noreply.github.com>
Co-authored-by: danholdaway <danholdaway@users.noreply.github.com>
Co-authored-by: Cory Martin <cory.r.martin@noaa.gov>
Co-authored-by: andytangborn <71304161+andytangborn@users.noreply.github.com>
Co-authored-by: Stephen Herbener <32968781+srherbener@users.noreply.github.com>
Co-authored-by: HamidehGMAO <40796921+HamidehGMAO@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants