Feature/ufs

[mark-a-potts]

Description

This PR adds input data for coupled ufs-jedi regression tests using a C48 warm start case as the basis.

What problem does it fix? What new capability does it add?

This allows for testing of the UFS-JEDI interface via the new ufs-jedi-bundle.

• fixes Add regression testing of UFS to ufs-jedi-bundle #23

Acceptance Criteria (Definition of Done)

Regression tests 40 and 44 under fv3-jedi repo will run and pass when the ufs-jedi-bundle is built.

[aerorahul]

Looks good.
I have a question on if cold start INPUT's are used/needed.
Files that are gfs_data.tileX.nc and sfc_data.tileX.nc
The oro_data.tileX.nc should be named C48_oro_data_tileX.nc for consistency with the grid_tile.nc
Also, the grid_spec.nc is a C48_mosaic.nc or C48_grid_spec.nc
Basically, files with resolution and fix files could be separated out instead of putting them in INPUT. This will help in future when resolution is made variable.
Just a thought.

[mark-a-potts]

Looks good. I have a question on if cold start INPUT's are used/needed. Files that are gfs_data.tileX.nc and sfc_data.tileX.nc The oro_data.tileX.nc should be named C48_oro_data_tileX.nc for consistency with the grid_tile.nc Also, the grid_spec.nc is a C48_mosaic.nc or C48_grid_spec.nc Basically, files with resolution and fix files could be separated out instead of putting them in INPUT. This will help in future when resolution is made variable. Just a thought.

I don't think I can make those changes without changing code in the UFS, but if there is some other configuration file that controls that, I am happy to make the change.

[climbfuji]

This won’t work, I think. You’ll have to create symbolic links. Or change the UFS (GFDL_atmos_cubed_sphere and fv3atm) code, as you said.

…

On Feb 1, 2022, at 12:19 PM, Mark Potts ***@***.***> wrote: Looks good. I have a question on if cold start INPUT's are used/needed. Files that are gfs_data.tileX.nc and sfc_data.tileX.nc The oro_data.tileX.nc should be named C48_oro_data_tileX.nc for consistency with the grid_tile.nc Also, the grid_spec.nc is a C48_mosaic.nc or C48_grid_spec.nc Basically, files with resolution and fix files could be separated out instead of putting them in INPUT. This will help in future when resolution is made variable. Just a thought. I don't think I can make those changes without changing code in the UFS, but if there is some other configuration file that controls that, I am happy to make the change. — Reply to this email directly, view it on GitHub <#24 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5C2RL6XZSLP3QQAWKSR63UZAW5ZANCNFSM5MZART5Q>. Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because your review was requested.

[aerorahul]

Correct. It won't work at execution time. At execution time they need to be resolution agnostic. However, in the git-lfs repository, when storing them, they should have the resolution in their name. That was my intent in the comment.

[climbfuji]

Correct. It won't work at execution time. At execution time they need to be resolution agnostic. However, in the git-lfs repository, when storing them, they should have the resolution in their name. That was my intent in the comment.

Oh yes, agreed.

[climbfuji]

@aerorahul Have your questions/comments been addressed?

@mark-a-potts Where are we with this PR?

[mark-a-potts]

I have renamed all the tile files in git-lfs with the C48_ prefix.

[climbfuji]

Thanks for adding the C48_ prefices. Looks good, and the tests in https://github.com/JCSDA-internal/fv3-jedi/pull/282 are now passing as well.

[aerorahul]

Looks good.
Thanks for addressing the comments on the resolution.
Just a note here that several resolution agnostic files are being stored under ufs_c48/ e.g aerosol.dat
Next time, is someone adds another resolution, please make sure that these files are organized properly to avoid unnecessary duplication in the repository.

[climbfuji]

Superseded by #52