Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding frame config option and removing electron remote library #1471

Merged

Conversation

IsmaelMartinez
Copy link
Owner

@IsmaelMartinez IsmaelMartinez commented Nov 9, 2024

  • Adding frame config option to allow for frameless windows. Closes Hide Title Bar #1444
  • Remove @electron/remote as I believe is not in use.

Copy link

sonarcloud bot commented Nov 9, 2024

@IsmaelMartinez IsmaelMartinez changed the title Adding frame config option, only installing production packages and removing electron remote library Adding frame config option and removing electron remote library Nov 9, 2024
@IsmaelMartinez IsmaelMartinez merged commit c2bc570 into main Nov 9, 2024
11 checks passed
@Shadowfury22
Copy link

Shadowfury22 commented Nov 11, 2024

Uhmm... shouldn't this have a default value of "true" instead of "false"?

frame: {
	default: false,
	describe: 'Specify false to create a Frameless Window. Default is true',
	type: 'string'
},

I got jumpscared by the lack of title bar after updating to 1.11.4 😅

@IsmaelMartinez
Copy link
Owner Author

IsmaelMartinez commented Nov 11, 2024 via email

@IsmaelMartinez
Copy link
Owner Author

ok, https://github.com/IsmaelMartinez/teams-for-linux/releases/tag/v1.11.5 should have that as a optional option, not the default. Thanks again for reporting it!

@IsmaelMartinez IsmaelMartinez deleted the feature/frameless-window-and-reduce-bundling-size branch November 25, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide Title Bar
2 participants