-
-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide Title Bar #1444
Comments
Hey, can you find the options in electron? Last time I tried this it was a frameless window (meaning, you only see the app, like a kiosk) that covers the whole screen. Things might have changed, as they changed in the past. It used to be possible but then they removed it. If you can find more info, I would be happy to check if we can try it out. |
nope, I was wrong and I think there is a wee bug. Probably when I was doing some refactoring a while ago. It does do full screen, so not hiding the bar as such. I will see when I got some time to fix it. Nice catch and thanks for reporting. |
Thank you very much! |
The bug should be fixed in https://github.com/IsmaelMartinez/teams-for-linux/releases/tag/v1.11.2 (pre-release). Can you confirm? Thanks |
thanks, it works in full screen mode anyways, thanks for the hard work |
I don't think this is possible in linux with electron, sorry. Maybe request this as a feature request in electron. |
I believe it is - I'm using owa-desktop and I added the following to the create window: const window = new BrowserWindow({
width: 1280,
height: 720,
title: `Outlook Desktop - ${email}`,
icon: __dirname + "images/Outlook.ico",
autoHideMenuBar: true,
frame: false,
webPreferences: {
spellcheck: true,
webSecurity: true,
contextIsolation: false,
webviewTag: true,
nodeIntegration: true,
nativeWindowOpen: true,
session: ses,
webviewTag: true,
nodeIntegration: false,
contextIsolation: true,
},
}); the |
@jorge-uptio there is no command-line option in the app. |
BrowserWindow is deprecated so I will suggest we only try to implement this after we have move away from it to the WebContentView. We already got a lot of things breaking from that migration and adding extra changes now will make it move complex. I will reopen this but mark it as blocked for those reasons, hope you understand as 3/4 other issues are already block for that migration that will otherwise block future migrations. |
Ok, I added a Let us know how you get on. This feature might go away once we move to the WebContentView, but hopefully it doesn't |
https://github.com/IsmaelMartinez/teams-for-linux/releases/tag/v1.11.5 has this as an optional, not the default. That was a mistake from me. |
Is your feature request related to a problem? Please describe.
I'm trying to hide the title-bar in liinux, I know it's possible using electron, just can't find it in this app.
I also know there's an older issue on this topic - but doesn't seem to work properly issue
Describe the solution you'd like
Have a flag in the configuration to activate it the "frame: false" option in electron when creating the window
Thanks!
The text was updated successfully, but these errors were encountered: