Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Title Bar #1444

Closed
jorge-uptio opened this issue Oct 12, 2024 · 11 comments · Fixed by #1471
Closed

Hide Title Bar #1444

jorge-uptio opened this issue Oct 12, 2024 · 11 comments · Fixed by #1471
Labels
blocked This issue depends on external projects

Comments

@jorge-uptio
Copy link

Is your feature request related to a problem? Please describe.
I'm trying to hide the title-bar in liinux, I know it's possible using electron, just can't find it in this app.
I also know there's an older issue on this topic - but doesn't seem to work properly issue

Describe the solution you'd like
Have a flag in the configuration to activate it the "frame: false" option in electron when creating the window

Thanks!

@IsmaelMartinez
Copy link
Owner

Hey, can you find the options in electron? Last time I tried this it was a frameless window (meaning, you only see the app, like a kiosk) that covers the whole screen.

Things might have changed, as they changed in the past. It used to be possible but then they removed it.

If you can find more info, I would be happy to check if we can try it out.

@IsmaelMartinez
Copy link
Owner

IsmaelMartinez commented Oct 13, 2024

nope, I was wrong and I think there is a wee bug. Probably when I was doing some refactoring a while ago. It does do full screen, so not hiding the bar as such. I will see when I got some time to fix it. Nice catch and thanks for reporting.

@jorge-uptio
Copy link
Author

Thank you very much!

@IsmaelMartinez
Copy link
Owner

The bug should be fixed in https://github.com/IsmaelMartinez/teams-for-linux/releases/tag/v1.11.2 (pre-release). Can you confirm? Thanks

@jorge-uptio
Copy link
Author

thanks, it works in full screen mode
I was wondering if there were a solution to remove the title bar when not in full screen mode

anyways, thanks for the hard work

@IsmaelMartinez
Copy link
Owner

I don't think this is possible in linux with electron, sorry. Maybe request this as a feature request in electron.

@jorge-uptio
Copy link
Author

I believe it is - I'm using owa-desktop and I added the following to the create window:

const window = new BrowserWindow({
    width: 1280,
    height: 720,
    title: `Outlook Desktop - ${email}`,
    icon: __dirname + "images/Outlook.ico",
    autoHideMenuBar: true,
    frame: false,
    webPreferences: {
      spellcheck: true,
      webSecurity: true,
      contextIsolation: false,
      webviewTag: true,
      nodeIntegration: true,
      nativeWindowOpen: true,
      session: ses,
      webviewTag: true,
      nodeIntegration: false,
      contextIsolation: true,
    },
  });

the frame: flase, allowed me to do it - just don't know how to do it in your app.
hope that makes sense

@jijojosephk
Copy link
Collaborator

@jorge-uptio there is no command-line option in the app. frame:false can only be used when creating a new window. So it can be implemented only as a start up parameter.

@IsmaelMartinez
Copy link
Owner

BrowserWindow is deprecated so I will suggest we only try to implement this after we have move away from it to the WebContentView.

We already got a lot of things breaking from that migration and adding extra changes now will make it move complex.

I will reopen this but mark it as blocked for those reasons, hope you understand as 3/4 other issues are already block for that migration that will otherwise block future migrations.

@IsmaelMartinez
Copy link
Owner

Ok, I added a frame config option that you can try to use. See version https://github.com/IsmaelMartinez/teams-for-linux/releases/tag/v1.11.4

Let us know how you get on. This feature might go away once we move to the WebContentView, but hopefully it doesn't

@IsmaelMartinez
Copy link
Owner

https://github.com/IsmaelMartinez/teams-for-linux/releases/tag/v1.11.5 has this as an optional, not the default. That was a mistake from me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This issue depends on external projects
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants