Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine disabling gpu & fix render-process-gone logging #1385

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

GrzegorzKozub
Copy link
Contributor

@GrzegorzKozub GrzegorzKozub commented Aug 29, 2024

Relates to #1369. Example of the log message:

08:03:09.099 › render-process-gone {"reason":"killed","exitCode":9}

app/index.js Outdated
console.error(`render-process-gone with reason: '${details.reason}'.`);
console.error(`Event '${event}' and details '${details}'`);
function onRenderProcessGone(event, webContents, details) {
// https://www.electronjs.org/docs/latest/api/app#event-render-process-gone
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this commented lines. Is ok to remove them

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@IsmaelMartinez
Copy link
Owner

Thanks @GrzegorzKozub for contributing. Would you be able to increase the version number and update the appdata files? There is a bit more info in https://github.com/IsmaelMartinez/teams-for-linux/blob/develop/CONTRIBUTING.md#release-process

Thanks again!

@GrzegorzKozub
Copy link
Contributor Author

Thanks @GrzegorzKozub for contributing. Would you be able to increase the version number and update the appdata files? There is a bit more info in https://github.com/IsmaelMartinez/teams-for-linux/blob/develop/CONTRIBUTING.md#release-process

Thanks again!

Done

Copy link

@IsmaelMartinez
Copy link
Owner

Thanks for the MR I will merge it now and hopefully release it later. Takes long enough (5 minutes) for me to forget I have trigger it 😄

@IsmaelMartinez IsmaelMartinez merged commit de1391e into IsmaelMartinez:develop Sep 2, 2024
3 checks passed
@IsmaelMartinez
Copy link
Owner

yep, I did forget but is now out! Thanks again for contributing https://github.com/IsmaelMartinez/teams-for-linux/releases/tag/v1.9.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants