-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refine disabling gpu & fix render-process-gone logging #1385
Conversation
app/index.js
Outdated
console.error(`render-process-gone with reason: '${details.reason}'.`); | ||
console.error(`Event '${event}' and details '${details}'`); | ||
function onRenderProcessGone(event, webContents, details) { | ||
// https://www.electronjs.org/docs/latest/api/app#event-render-process-gone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need this commented lines. Is ok to remove them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
Thanks @GrzegorzKozub for contributing. Would you be able to increase the version number and update the appdata files? There is a bit more info in https://github.com/IsmaelMartinez/teams-for-linux/blob/develop/CONTRIBUTING.md#release-process Thanks again! |
Done |
|
Thanks for the MR I will merge it now and hopefully release it later. Takes long enough (5 minutes) for me to forget I have trigger it 😄 |
yep, I did forget but is now out! Thanks again for contributing https://github.com/IsmaelMartinez/teams-for-linux/releases/tag/v1.9.6 |
Relates to #1369. Example of the log message: