Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Frameless / Hide Title Bar #185

Closed
rt3norio opened this issue Jul 24, 2019 · 8 comments
Closed

Enable Frameless / Hide Title Bar #185

rt3norio opened this issue Jul 24, 2019 · 8 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@rt3norio
Copy link

Is your feature request related to a problem? Please describe.
I would like to be able to remove the window title bar, so i can have bigger 'work area' when on fullscreen, because my notebook resolution is not great.

Describe the solution you'd like
I would like to have a setting or checkbox that on the next app start would remove the title bar.

Describe alternatives you've considered
I could press F11 to achieve the same funcionality

Additional context
I don't think there is any more information that i can give

Thanks in advance

@IsmaelMartinez IsmaelMartinez added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jul 24, 2019
@IsmaelMartinez
Copy link
Owner

IsmaelMartinez commented Jul 24, 2019

Thanks for the feature request.

I think this will be possible by using a Frameless window https://electronjs.org/docs/api/frameless-window#frameless-window

Adding frame: false to this line should do:
https://github.com/IsmaelMartinez/teams-for-linux/blob/develop/app/mainAppWindow/index.js#L87

To make it configurable, follow the config.webDebug approach from line: https://github.com/IsmaelMartinez/teams-for-linux/blob/develop/app/mainAppWindow/index.js#L47

That is pulled from the config folder https://github.com/IsmaelMartinez/teams-for-linux/tree/develop/app/config

I have no time at the moment but happy to merge PRs

@rt3norio
Copy link
Author

I'm gonna try it on this weekend.
With your guidelines, probably will be easy.
Thanks!

@IsmaelMartinez
Copy link
Owner

Let me know if you need more info/help. Might be easier to chat in gitter channel.

@IsmaelMartinez
Copy link
Owner

Updated the links after the refactoring.

@IsmaelMartinez
Copy link
Owner

hey @rt3norio , let me know if you need any extra help. You can always add a PR with where you are and I can guide you a bit more. Thanks!

@IsmaelMartinez
Copy link
Owner

When down the route of the menu option. Electron has a few menu options that can be added and the toggle.

From here: https://electronjs.org/docs/api/menu-item?q=togglefullscreen#menuitemmenu

I will close this as this fulfils your alternative solution. It should be in snap edge 0.6.4 (building as I write)

@IsmaelMartinez
Copy link
Owner

just pre-released 0.6.6 so people that don't use snap can test it also.
https://github.com/IsmaelMartinez/teams-for-linux/releases/tag/v0.6.6

@drupol
Copy link

drupol commented May 15, 2023

What's the status of this issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants