-
-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can you please sign in again? #1045
Comments
I believe that would be due your company policy (how long the session lasts). It is true that the app should handle better this but I am really not sure where to start. |
I am having the same issue. Started when my company enabled MFA. Here is the error I get every few hours: Session ID: c80b10a8-4f9e-2e3d-4839-a332fca66453 Here is something I read about this issue and a possible fix: Hi, https://docs.microsoft.com/de-de/azure/active-directory/develop/reference-third-party-cookies-spas The error messages is maybe misleading or my understanding is not right. To prevent this, is one solution to add the authorization side from MS to the intranet-zone so it is not third-party? Does this make any sense with this app ? I know you are using the MS Teams Web app wrapped in Electron. Is there a way to test this by "enabling 3rd party cookies" in Electron ? Sorry if this is a stupid idea... |
Did not hear from anyone on this issue ? Still get nag to re-authenticate many many times a day > 25. Driving me CRAZY !! Please help ! |
You can try using the certificates if your company allows that. Using clientCertPath clientCertPassword from the config options https://github.com/IsmaelMartinez/teams-for-linux/tree/develop/app/config |
The same happens here for a while now, and still with 1.4.6 installed:
And yes, while the error appears to be documented this doesn't really help:
|
This happens when the session times out and the webapp launches some url probably to re-login. To avoid external urls being opened in the same context |
@mikedld can you try |
@jijojosephk, seeing an unintrusive notification instead of links being opened in a browser, so seems that it's working. Manually opening other links (external, or internal to e.g. channels) still works as expected too. And I'm still asked to relogin a bit later, after a few such notifications, which is good. I suppose the notification is there for debugging purposes and isn't strictly necessary, but I don't mind either way — it's much better than before now. Thanks! ;) Just in case, my issue was with those links being opened, not with me being asked to re-login which is expected in my case. Performing automatic re-login will supposedly require you to store the credentials somewhere and use them to satisfy the request in the background which the official client doesn't do (as it'll defeat the security feature that expects human interaction to happen), and which also may be an unnecessary complication for you, so I'm not that interested in it (although won't mind it either). Still, it's not what OP asked for. |
The new 1.4.13 version fixed the randomly opened browser tabs, and it looks like nothing broke. And I don't have the "please sign in again" problem (and didn't have it before). Also, what is the plan with the blocked URLs to go forward? As the changelog says it's only a temporary solution, but it's already helping a lot how it is now. |
1.4.13 has really made a positive improvement.
I don’t get the “Please sign in again” errors anymore either !!!
Thanks !!!
This works AWESOME !!!
Kevin K.
From: Benjamin Neff ***@***.***>
Sent: Tuesday, March 5, 2024 6:07 PM
To: IsmaelMartinez/teams-for-linux ***@***.***>
Cc: KKomara62 ***@***.***>; Comment ***@***.***>
Subject: Re: [IsmaelMartinez/teams-for-linux] Can you please sign in again? (Issue #1045)
The new 1.4.13 version fixed the randomly opened browser tabs, and it looks like nothing broke. And I don't have the "please sign in again" problem (and didn't have it before). Also, what is the plan with the blocked URLs to go forward? As the changelog says it's only a temporary solution, but it's already helping a lot how it is now.
—
Reply to this email directly, view it on GitHub <#1045 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/BE2IHQ7AU6UJZUM4FDI76LLYWZFXRAVCNFSM6AAAAABAYEE3WSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZZG44DSMZXGQ> .
You are receiving this because you commented. <https://github.com/notifications/beacon/BE2IHQ5ZSMPN7CAD7Q4BIILYWZFXRA5CNFSM6AAAAABAYEE3WSWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTWAEYD4.gif> Message ID: ***@***.*** ***@***.***> >
|
Thanks @mikedld @SuperTux88 @KKomara62 for trying out the new build. @SuperTux88, I mentioned temporary because the problem was super annoying and I personally wanted to ease the pain for people who face this while we figure out what could be the best possible solution. Like, should we allow the URLs instead of blocking. Like I mentioned in other comments, if we allow the requests, it's possible that you'd lose an ongoing meeting because the page might reload. We can try it by allowing a whitelisted URLs. Which one's to be allowed? the |
It looks like none of the blocked URLs are supposed to be opened in an external browser, as they don't work there and only open pages showing error messages (because the browser doesn't have the session that is active in teams-for-linux). But at the moment it looks like it's also not breaking anything if these requests are just blocked? But maybe opening them in an (invisible) iframe or something where they have access to the teams session might be a solution, in case these requests are still important for something? 🤔 |
I suspect it's a 1/2 or 1/3 lifetime token refresh or similar, where it's doign a refresh operation to keep it current, but if it's missed, it still continues to work until the full expiration. (Think renewing a dhcp lease.) |
Yes, in the next release we'll add the ability to allow certain URLs then we can study the behavior. |
In the past we had to open URLs in the background (I don't remember what it
was for). I suspect these are either token refresh or sending analytics to
Microsoft.
Great job Jijo!
…On Thu, Mar 7, 2024 at 8:34 AM Jijo Joseph ***@***.***> wrote:
It looks like none of the blocked URLs are supposed to be opened in an
external browser, as they don't work there and only open pages showing
error messages (because the browser doesn't have the session that is active
in teams-for-linux). But at the moment it looks like it's also not breaking
anything if these requests are just blocked? But maybe opening them in an
(invisible) iframe or something where they have access to the teams session
might be a solution, in case these requests are still important for
something? 🤔
Yes, in the next release we'll add the ability to allow certain URLs then
we can study the behavior.
—
Reply to this email directly, view it on GitHub
<#1045 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADJHEGXO5FUBTWBPBQYPW3YXARCHAVCNFSM6AAAAABAYEE3WSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBSHE2DEMZUGQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Yes, I think these URLs would be needed to be opened in the background somehow, as opening them in an external browser doesn't do anything if it's for stuff like token refresh (as the browser doesn't have access to the session/tokens). So a config to allow certain URLs wouldn't help, if these allowed URLs then are still opened in an external browser. |
It's to allow internally. No more external browser. |
hi @yermulnik , this is probably your company policy asking to re-authenticate every few hours, but that is blocked, so your token expires. In theory, enabling this URLs to go in the background might sort the re-authentication problem, but MS keeps changing and/or adding URLs every now and then, making this an annoying task. If you can use a certificate (as describe in one of the comments above) this should remove the problem (as it should not require re-authentication, as far as I am aware). I am not sure when we will be able to make that "open those urls in the background" change, but we are more than happy for contributors to step in. |
@IsmaelMartinez Got it. Thanks for the details. |
FWIW and just for tracking:
|
Note that after switching to Teams 2.0, this is no longer an issue for me (or has been reduced to a minor annoyance). Instead of getting the white screen of death "Can you please sign in again" prompt (almost daily with 1.0), it seems like Teams 2.0 will simply display a non-invasive red bar at the top reading "We weren't able to connect. Sign in and we'll try again." Then clicking on the "Sign in" button to the right of the message seems to work fine, getting me back in without fuss. And then I'm good for a few days. So far I haven't been thrown off in the middle of a meeting. Whereas with 1.0, this would happen often and only a "Clear storage" would fix the problem. In fact, I haven't needed to "Clear storage" once since moving to Teams 2.0 in March. In the end, I feel 2.0 handles this more gracefully. Hopefully others can confirm. YMMV. |
Yep, I can confirm the same improvement. |
Not sure if using the inTune login might be useful for some of you? See https://github.com/IsmaelMartinez/teams-for-linux/pull/1280/files |
From my understanding, this is now sort of fixed. I am going to close this as it does look like the blocking of URLs does the job. I prefer to keep them block so we reduce tracking capabilities by MS (so you are a tiny bit safer). But do write back if this is still not working and I can re-open. |
Describe the bug
Every few days, it says "Can you please sign in again?" as shown in the screenshot. It also says:
Sometimes I don't notice the problem for hours during which I miss calls from my coworkers.
Some issues reported in the bug database say that Teams asked them to sign in after they closed and restarted Teams. But in my case, I did not close Teams. I left it running and then it eventually showed the request to sign in again.
To Reproduce
Login to Teams For Linux and let it keep running for a few days.
Expected behavior
I expected to remain signed in as long as teams remained running.
Screenshots
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: