Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token/auth requests get sent to external browser #890

Closed
nneul opened this issue Jul 11, 2023 · 17 comments
Closed

Token/auth requests get sent to external browser #890

nneul opened this issue Jul 11, 2023 · 17 comments
Assignees
Labels
duplicate This issue or pull request already exists

Comments

@nneul
Copy link
Contributor

nneul commented Jul 11, 2023

Intermittent requests to elements within teams (files, tasks, etc.) trigger some additional authentication (likely getting a service specific token). SOMETIMES this seems to happen transparently, but others it winds up opening in external browser, which presents this error.

image

It's impossible to get past this since it's missing the content of the request. Additionally, depending on what you try to then do in the teams window, it will rapid fire create new/additional tabs with the same request.

This usually appears after teams app has been open for a while. (Next day?)

It seems like there is maybe some additional logic needed for 'when to open internally' vs 'when to open in external browser'.

The particular target URL in my case:

https://login.microsoftonline.com/e3fefdbe-f7e9-401b-a51a-355e01b05a89/oauth2/v2.0/token

https://login.microsoftonline.com//oauth2/v2.0/token

Desktop (please complete the following information):

  • OS: Ubuntu 20 x64
  • Installation package: deb from repo
  • Version: 1.1.11
@nneul
Copy link
Contributor Author

nneul commented Jul 11, 2023

Example of a dialog that triggers it:

image

@ChristoSnake
Copy link

I experience the same since upgrading to v1.2.4 this morning. I have not seen the trigger dialog, but I do have the browser tabs.

OS: openSUSE Tumbleweed 20230710, KDE Plasma v5.27.6, Wayland
Installation package: rpm
Version: teams-for-linux-1.2.4-1.x86_64

@jijojosephk
Copy link
Collaborator

I experience the same since upgrading to v1.2.4 this morning. I have not seen the trigger dialog, but I do have the browser tabs.

OS: openSUSE Tumbleweed 20230710, KDE Plasma v5.27.6, Wayland
Installation package: rpm
Version: teams-for-linux-1.2.4-1.x86_64

I had experienced this before the upgrade. MS did something. Everyone might not see, depends on organisational level settings or updates. 1.1.6 release mentions the same. App used to crash when this happens. With that release, the crash is fixed. But the browser window opens up. Multiples.. 2-3 I guess.

@jijojosephk jijojosephk self-assigned this Aug 11, 2023
@IsmaelMartinez
Copy link
Owner

are you still experiencing this issue?

@ChristoSnake
Copy link

I have not seen this in a while...

My company enforces re-authentication every two weeks, I will keep update here if it happens again.

@nneul
Copy link
Contributor Author

nneul commented Sep 5, 2023

I regularly still see this. Org doesn't have any 'frequent relogin' requirement (might be /30). Very often triggered if I go to any files tab or similar, but it doesn't do it every time - usually if I've been logged in for 24h or more.

@nneul
Copy link
Contributor Author

nneul commented Sep 5, 2023

Note that I almost daily see the 'Interaction required' dialog, but I think that's a separate issue.

image

@vpess
Copy link

vpess commented Sep 22, 2023

I solved this problem clearing Microsoft Teams cache. Clear cache Microsoft Teams on Linux

OS: Fedora Linux 38 (Workstation Edition)
Installation package: flatpak
Version: 1.2.9

@Stav88
Copy link

Stav88 commented Oct 4, 2023

I had same problem on version 1.3.6. Upgrading on 1.3.13 fix it on my side.
Does upgrading clear cache ?

OS : Ubuntu 22.04
Installation package : snap

Edit : Bug persist when I keep a session during more than one day

@rjeq
Copy link

rjeq commented Nov 24, 2023

Exact same dialog as @nneul here triggers it as well

teams-for-linux/stable,now 1.3.22 amd64 [installed]

@IsmaelMartinez
Copy link
Owner

Can you clean the cache and check if it still happens?

@nneul
Copy link
Contributor Author

nneul commented Nov 24, 2023

Unless you've added something within past few weeks - I definitely still see this, and I've done full resets and cache clean.

However, to clarify the symptom - I do NOT see this on "just the interaction required" - i.e. when the session sits. I only see it when accessing secondary pages/tabs within Teams. If it is just a regular "need to log back in", I see that even on plain browser session. (I usually have one of those open as well just for better meeting isolation and being able to have a second window.)

What usually triggers it for me is if the session is at all old, and I go to access something like the org tree for a person, or the files tab, or similar. The shared files one is particularly messy since it gets into a state where it's trying to "get additional permissions" and often winds up flooding my other active browser window with additional tabs -- and since those tabs are trying to open via a 'GET' since it's an external browser load, they don't work - they have to be a POST according to the target server.

That may be a possible avenue to explore --- do you have any means to say "Only open in external browser if the originating request is a GET/plain url, and force to open in internal browser if they are a POST or any other verb?"

@jijojosephk jijojosephk added the duplicate This issue or pull request already exists label Feb 20, 2024
@jijojosephk
Copy link
Collaborator

This could be related to #1045

@jijojosephk
Copy link
Collaborator

@nneul can you follow #1045. we'll discuss possible solution there. A lot of people commented there.

@desmi
Copy link

desmi commented Mar 4, 2024

I have this same issue, for me, it gets triggered when I'm in a meeting and want to send something in the meeting chat. Have been experiencing this for a while and when it happens I get about 5 windows opened in my external browser (Firefox).

@jijojosephk
Copy link
Collaborator

Try in 1.4.13

@IsmaelMartinez
Copy link
Owner

closing due inactivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

8 participants