-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Islandora 'Large Image' workflow #572
Comments
We should be able to replace our IIIF image server with whatever image server we choose in the future. But the default Islandora install should use one that doesn't require Kakadu to function. That keeps our licensing easier, and makes sure that we have a fully open source option, even if people choose to deploy in another way. That narrows down the possible options for a IIIF server substantially.
Loris-redux removed as it isn't complete. Based on this I'm thinking we should use IIPImage as our default in vagrant. Anyone have any other options I missed? Thoughts? |
Having looked at the three, I'm inclined to agree with you on IIP Image, and if that doesn't pan out, try digilib. I'd shy away from LORIS-redux, seems to have WIP warnings aplenty. |
This also seems like it may be fairly useful: |
That does indeed look useful. I wonder how well that would play with the Media entity thing we've got going on. Definitely worth investigating. |
Quick look at the code reveals it's a field formatter, which should be useable on a media entity no problem. This looks promising. |
Thus far my attempts to get IIP going with OpenJPEG are meeting with failure. I made a ticket above to see if they had any troubleshooting ideas. I'm going to abandon IIP for now and try using Cantaloupe. |
@dannylamb @jonathangreen we need to add islandora_image to claw_vagrant, right? If so, I'm happy to take care of that after #53 and islandora-deprecated/islandora_image#11 land. |
#618 added the ability to ingest TIFFs and JP2s, resolving two more check boxes on that list. |
I have an OpenSeadragon module. To test inside a claw_vagrant you need to:
Now for Cantaloupe. Edit the At line 110, you want
At line 129, you want
Close and save the file. Now in Drupal, go to Administration -> Structure -> Media Bundles. Beside JP2 choose the down arrow and select Manage Display. I'd remove all the fields except File and for the format choose OpenSeadragon, don't forget to save. Then go to Administration -> Configuration -> Media -> OpenSeadragon Settings Set the IIIF Image server location to The OpenSeadragon settings can be set or leave as default. Save the form. Create a new Islandora Image object, add a title, add a JP2 to the JP2 field. Save and publish. 🤞 See an image in Openseadragon? |
👍 @whikloj++ I'll give this a whirl after I'm done testing islandora-deprecated/claw_vagrant#46 |
@dannylamb I'm working on a PR to add this to claw_vagrant. Should I transfer this over to Islandora-CLAW now or would you like to look at it first? |
By "this" I meant, transfer https://github.com/whikloj/openseadragon to the Islandora-CLAW organization? |
@whikloj I was just going to install it myself, but I'll definitely take the claw_vagrant PR 👍 Let me look over the module first and then we'll transfer. |
@dannylamb give me a couple of seconds, I think I have it mostly worked out. That should be minutes, I need to do a |
@whikloj So I've got a few comments. But since there's no PR it's a bit hard to review. So i'm just gonna dump it here:
|
@dannylamb ok, I can do 1 and 2. I did think about tests, but right now I don't even have a good (non-deprecated) way to check the library version. So if you have the wrong library or your cantaloupe is not installed correctly. So much could be wrong. I could use the template and javascript to add a hidden tag, sort of a |
@whikloj Well let's do 1 and 2 and then I guess 3 falls squarely into my end-to-end integration test wishlist. |
Definitely seems like an end-to-end test, but wouldn't it be enough in that test to retrieve a single image tile and check it against a rubric? |
Followed the steps for openseadragon. Seems to install ok. Shows up as a format option. But it does not render the viewer or the image. How I can verify that http://localhost:8080/cantaloupe/iiif is working properly. As there are some other issues related to the image bundle, I'll re-test this again at a later time. |
@Natkeeran, @dannylamb pointed out that I had missed a step (or two) in my testing instructions. I have fixed them now so probably have to go back up and perform steps 12 & 13. But I'm still having intermittent luck with OpenJpeg. You might be better off to follow the same steps above but make OpenSeadragon the viewer for your OBJ media bundle and upload a Tiff. |
Oh, I forgot there is more. You may want to wait. But if not. |
@dannylamb @Natkeeran I haven't made a PR yet as I still need to have claw_vagrant update the default Islandora configuration to use OpenSeadragon for JP2s. |
@dannylamb I have no idea how to write a file for unit testing this FileInformation class. I need to have a reference to a file so it can be |
So I think I need to generate a media entity so I can reference it from the Entity so I can pass it into the method, maybe I'll switch the method back to just taking a |
@dannylamb forget my previous whining, I took my advice and altered the FileInformation class to operate on a File, which made it easier to mock up. I have added a fairly simple test to the module and I added the mime-type mappings for JP2 and Tiff to openseadragon as they are required to allow the image to display. Last piece is probably a I haven't been able to figure out how to export and import the config to alter to use openseadragon. I don't really want to depend on openseadragon in the individual modules. So I'll keep playing around and if I can figure it out then we can have So maybe test it out with my |
@whikloj++ |
@whikloj I just tested it and it works fine for Tiffs, but not for JP2. Just getting a black screen and this gem in the logs:
|
@dannylamb Can I try that JP2, I still get this type of error for a small 1 bit JP2 of mine, but the rest seem to work so perhaps the concern about OpenJpeg being twitchy about JP2 produced by other software is valid. 🤷♂️ |
@whikloj I'm testing with http://www.terracolor.net/download/tc_ng_tokyo_jp_jp2.zip. It's 20 MB, so I had to bump the max upload size in apache's php.ini. |
@whikloj And as a follow up, I'll generate a JP2 using Houdini and see how that goes. |
@dannylamb cool, I'm just rebuilding a fresh vagrant with my issue-572 branch and then I'll see what I can figure out. |
Hrm.. getting a black screen with a different error message after uploading a jp2 i generated with this tiff. I went to go see if it was a config thing and got the WSOD at
|
Follow up from IRC: We're going to take what works with Tiffs and put off JP2 support for later. |
@whikloj @jonathangreen Given that we've got everything checked off but JP2 support, and we've decided to put JP2s on hold for a bit, I think we're good to close this for now. |
Meta ticket to handle all of our 'large image' needs.
Serve JP2s from IIIFThe text was updated successfully, but these errors were encountered: