Skip to content
This repository was archived by the owner on Aug 18, 2020. It is now read-only.

Add imagemagick with JP2 support to bootstrap.sh #27

Merged

Conversation

jonathangreen
Copy link
Contributor

GitHub Issue

Part of:
Islandora/documentation#572

What does this Pull Request do?

Add imagemagick with JP2 support to bootstrap.sh. This is installed from a PPA that LYRASIS (me) maintains, for imagemagick with JP2 support.

How should this be tested?

  • vagrant up
  • convert image.jp2 image.png
  • make sure image.png looks okay

@jonathangreen
Copy link
Contributor Author

Another test for this one, after vagrant up you should see jp2 in the delegates.

convert --version
Version: ImageMagick 6.8.9-9 Q16 x86_64 2017-02-01 http://www.imagemagick.org
Copyright: Copyright (C) 1999-2014 ImageMagick Studio LLC
Features: DPC Modules OpenMP
Delegates: bzlib cairo djvu fftw fontconfig freetype jbig jng jp2 jpeg lcms lqr ltdl lzma openexr pangocairo png rsvg tiff webp wmf x xml zlib

@ruebot
Copy link
Contributor

ruebot commented Mar 28, 2017

@jonathangreen do you think it would be worth grabbing the latest version of imagemagick, all the dependencies, and compiling it from source?

@ruebot
Copy link
Contributor

ruebot commented Mar 28, 2017

Tested and PR works as described.

@jonathangreen
Copy link
Contributor Author

@ruebot we totally can just compile a new version of imagemagick.

The reason we are installing from a package at LYRASIS is that there are a lot of things that depend on the imagemagick shared library to provide image manipulation capability. The big one that comes to mind is the php imagemacgick extension. When you get into compiling imagemagick if you are providing your new shared library then everything looking for the older version of the shared library needs to be recompiled, or can have some unexpected behaviour. the PHP extension checks the imagemagick version and throws errors if its incorrect.

The other option for compiling is to keep the version from package management installed, and just compile a new version, with everything statically linked, so we can just call out to just the new version of the command line utils. This works to have a new version, but none of the other dependancies benefit from the extra delegates.

I'm a fan of just recompiling the package with JP2 enabled as was done here, but I'm open to either option above as well.

@ruebot
Copy link
Contributor

ruebot commented Mar 29, 2017

@jonathangreen I forgot to include the php extension in my thought process. The work I'm doing with the most recent version of Imagemagick doesn't require on it. So, I'm cool with we're doing here. ...and as an aside, @dannylamb and I have been kicking around the idea of having some kind of apt-package for CLAW, so it's good that we have more expertise there.

@ruebot ruebot merged commit 54cb966 into islandora-deprecated:master Mar 29, 2017
@jonathangreen jonathangreen deleted the issue-572-imagemagic branch March 29, 2017 12:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants