-
Notifications
You must be signed in to change notification settings - Fork 45
cardano-base: initialize with CardanoFeatureFlag
#547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This looks great to me; addressed all of the concerns I voiced during the call in which this idea was proposed. Maybe add |
31cde8d to
7379647
Compare
CardanoFeatureFlag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just a few minor changes requested
7379647 to
c5b42a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Description
This PR adds a new library
cardano-basethat, for now, only contains a very simple module with a feature flag sum type.In the future, more functionality might be added/moved to
cardano-base(potentially as a sublibrary), in contrast to the existing narrowly-scoped packages in this repo.Addresses tweag/cardano-peras#96
See eg IntersectMBO/ouroboros-network@c330acc for a potential real-world usage example
Checklist
CHANGELOG.mdfor the affected packages.New section is never added with the code changes. (See RELEASING.md)
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated.If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)