Skip to content

Conversation

@amesgen
Copy link
Member

@amesgen amesgen commented Sep 10, 2025

Description

This PR adds a new library cardano-base that, for now, only contains a very simple module with a feature flag sum type.

In the future, more functionality might be added/moved to cardano-base (potentially as a sublibrary), in contrast to the existing narrowly-scoped packages in this repo.

Addresses tweag/cardano-peras#96

See eg IntersectMBO/ouroboros-network@c330acc for a potential real-world usage example

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages.
    New section is never added with the code changes. (See RELEASING.md)
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated.
    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Self-reviewed the diff

@nfrisby
Copy link
Contributor

nfrisby commented Sep 10, 2025

This looks great to me; addressed all of the concerns I voiced during the call in which this idea was proposed.

Maybe add Read to the deriving clause, for easier QuickCheck debugging cycle.

@amesgen amesgen force-pushed the feature-flags branch 2 times, most recently from 31cde8d to 7379647 Compare September 10, 2025 14:38
@amesgen amesgen changed the title cardano-feature-flags: initialize cardano-base: initialize with CardanoFeatureFlag Sep 10, 2025
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a few minor changes requested

Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants