[WIP] Add ObjectDiffusion miniprotocol for Peras cert and vote diffusion #5181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coot
reviewed
Aug 7, 2025
ouroboros-network-protocols/src/Ouroboros/Network/Protocol/ObjectDiffusion/Type.hs
Outdated
Show resolved
Hide resolved
ouroboros-network-protocols/src/Ouroboros/Network/Protocol/ObjectDiffusion/Type.hs
Outdated
Show resolved
Hide resolved
ouroboros-network-protocols/src/Ouroboros/Network/Protocol/ObjectDiffusion/Type.hs
Outdated
Show resolved
Hide resolved
ouroboros-network-protocols/src/Ouroboros/Network/Protocol/ObjectDiffusion/Type.hs
Outdated
Show resolved
Hide resolved
ouroboros-network-protocols/src/Ouroboros/Network/Protocol/ObjectDiffusion/Type.hs
Outdated
Show resolved
Hide resolved
ouroboros-network-protocols/src/Ouroboros/Network/Protocol/ObjectDiffusion/Type.hs
Outdated
Show resolved
Hide resolved
ouroboros-network-protocols/src/Ouroboros/Network/Protocol/ObjectDiffusion/Type.hs
Outdated
Show resolved
Hide resolved
ouroboros-network-protocols/src/Ouroboros/Network/Protocol/ObjectDiffusion/Type.hs
Outdated
Show resolved
Hide resolved
coot
reviewed
Aug 7, 2025
ouroboros-network-protocols/src/Ouroboros/Network/Protocol/ObjectDiffusion/Type.hs
Outdated
Show resolved
Hide resolved
Member
|
@coot Thanks for the comments! Note though that this is early stage code (ie this is a draft PR), not yet intended for review by the Network team 😅 |
amesgen
force-pushed
the
peras/object-diffusion
branch
from
5f76136 to
bca44ca
Compare
tbagrel1
force-pushed
the
peras/object-diffusion
branch
from
7f76338 to
62e51e4
Compare
tbagrel1
commented
Sep 5, 2025
ouroboros-network-api/src/Ouroboros/Network/NodeToNode/Version.hs
Outdated
Show resolved
Hide resolved
ouroboros-network-protocols/src/Ouroboros/Network/Protocol/ObjectDiffusion/Inbound.hs
Outdated
Show resolved
Hide resolved
Member
|
To prevent garbage-collection of commits: |
7 tasks
nbacquey
force-pushed
the
peras/object-diffusion
branch
from
ea5de71 to
01d1928
Compare
Collaborator
|
To prevent garbage collection still: faf54aa |
amesgen
approved these changes
Sep 16, 2025
Member
amesgen
left a comment
amesgen
left a comment
There was a problem hiding this comment.
LGTM! I think we can squash this into two commits, one which adds the new NodeToNodeV_16, and another one that adds everything else.
ouroboros-network-protocols/src/Ouroboros/Network/Protocol/ObjectDiffusion/Codec.hs
Show resolved
Hide resolved
ouroboros-network-protocols/src/Ouroboros/Network/Protocol/ObjectDiffusion/Codec.hs
Outdated
Show resolved
Hide resolved
nbacquey
force-pushed
the
peras/object-diffusion
branch
from
faf54aa to
7209cec
Compare
tbagrel1
force-pushed
the
peras/object-diffusion
branch
from
9cea5df to
2a847d7
Compare
Co-authored-by: Agustin Mista <[email protected]> Co-authored-by: Alexander Esgen <[email protected]> Co-authored-by: Georgy Lukyanov <[email protected]> Co-authored-by: Thomas BAGREL <[email protected]> Co-authored-by: Nicolas BACQUEY <[email protected]> Co-authored-by: Nicolas "Niols" Jeannerod <[email protected]>
Co-authored-by: Agustin Mista <[email protected]> Co-authored-by: Alexander Esgen <[email protected]> Co-authored-by: Georgy Lukyanov <[email protected]> Co-authored-by: Thomas BAGREL <[email protected]> Co-authored-by: Nicolas BACQUEY <[email protected]> Co-authored-by: Nicolas "Niols" Jeannerod <[email protected]>
tbagrel1
force-pushed
the
peras/object-diffusion
branch
from
2a847d7 to
fabffbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes tweag/cardano-peras#57. IntersectMBO/ouroboros-consensus#1615 depends on this PR.
Defines a new miniprotocol, ObjectDiffusion, highly inspired from TxSubmission, in which two peers are able to exchange abstract objects identified by IDs.
On a side note, this PR also adds a new miniprotocol parameter (and a corresponding default value) for the number of certs to ack for PerasCert diffusion (based on ObjectDiffusion).