-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style(loader): Replace all loaders with centered blue circular spinner #927
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, I have only one question. I added it inline. Overall, this is a good PR. After my question is answered, I will continue the code review. Thanks.
<div class="row q-col-gutter-md"> | ||
<div class="col-6"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you change the style here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert the changes here
</QCardSection> | ||
</QCard> | ||
</div> | ||
<div class="col"> | ||
<div class="col-6"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, here the change of style is related to the changes in 643.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert the changes here
@dpgiakatos i have done the changes in these style beacuse when i was solving the issue then i was facing a problem that charts Alarms over Time and Alarms by Severities were appearing one below the other instead of in the same row as intended therefore i tried to change the style to solve this and done the above changes and just now when i revert these style changes in my local then i found that there is much not big problem but with these changes charts are taking half of the container width and ensuring a consistent and balanced layout.. if you did prefer to revert these changes please let me know.. |
This depends on the screen size and your screen resolution. Before making any changes in the style, make sure that you have tried all the available screen sizes and resolutions. If you have not tested them, then you should either test them and have a detailed report or revert to the previous settings. |
If adding the new loading component breaks the page, then you should adjust the loading component, not the page itself. |
@dpgiakatos when i revert the above style then also its working fine and no page break is there then should i revert these changes ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address my inline comments. Thank you.
<div class="row q-col-gutter-md"> | ||
<div class="col-6"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert the changes here
</QCardSection> | ||
</QCard> | ||
</div> | ||
<div class="col"> | ||
<div class="col-6"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert the changes here
Hello @dpgiakatos i have done the changes as per instructed please review it .. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Description
Replaced the default triangular loader with the blue circular spinner to maintain UI consistency across the site. Updated the corresponding CSS and markup without affecting functionality.
Related issue
#924
Screenshots (if appropriate):
Types of changes
Checklist: