Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Similar Loader inconsistent issue on other pages of website also #924

Closed
abansal15 opened this issue Mar 4, 2025 · 6 comments
Closed

Similar Loader inconsistent issue on other pages of website also #924

abansal15 opened this issue Mar 4, 2025 · 6 comments
Assignees
Labels

Comments

@abansal15
Copy link
Contributor

Describe the bug
When today i was exploring other pages of website i noticed similar loader inconsistent issue on the other pages also there are different types of loader deafult triangular, Horizontal moving bar, Loading...
Below is the URLS of the pages where i have found this issue

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://www.ihr.live/en/global-report?filter_level=1&last=1&date=2025-03-04

  2. See error

  3. Go to https://www.ihr.live/en/rov?af=4&last=3&date=2025-03-04&rov_tb=routes

  4. See error

Expected behavior
At all places there should be similar loader which is at across the website

Screenshots

Screen.Recording.2025-03-04.081326.mp4
@abansal15
Copy link
Contributor Author

abansal15 commented Mar 4, 2025

Hello @dpgiakatos can you please asisgn this issue to me.. this is very similar to the previous task that i have done..
To solve this issue i have to do changes in the files
ROV.vue , AggregatedAlarmsController.vue

I think these different loader styles are part of the default behavior of the components or libraries we are using. For example, some Quasar components (like QTable) have a built-in loader that appears as a triangular warning or a moving horizontal line if no custom loader slot is provided

@abansal15
Copy link
Contributor Author

Below is expected behavior at Global Report page

Image

@dpgiakatos
Copy link
Member

Nice finding, you can work on this.

@abansal15
Copy link
Contributor Author

Thanks @dpgiakatos

@abansal15
Copy link
Contributor Author

Hello @dpgiakatos i have raised the pr and tested it hopefully there is not any problem please review it

@abansal15
Copy link
Contributor Author

abansal15 commented Mar 5, 2025

and @dpgiakatos i have already solved the issue at site
https://www.ihr.live/en/rov?af=4&last=3&date=2025-03-04&rov_tb=routes
in my previous pr as it is importing the PrefixHegemonyChart.vue component only and i have fixed it in my previous pr.. actually changes was not live at deployed site therfore i though there is also need of chamge in this site also

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants