Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix in ros_topic_wait_for_topics action #101

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

fmirus
Copy link
Contributor

@fmirus fmirus commented Jun 27, 2024

Description

ros_topic_wait_for_topics action was missing the name argument which results in parsing error

OSC2ParsingError: Error while initializing plugin wait_for_topics: RosTopicWaitForTopics.__init__() got an unexpected keyword argument 'name'

Pull request checklist

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • Format and Lint checks (make check) pass locally
  • PR applies Apache 2.0 License to all code files

Pull request type

  • Bugfix

Current behavior

using the ros_topic_wait_for_topics action results in parsing error

OSC2ParsingError: Error while initializing plugin wait_for_topics: RosTopicWaitForTopics.__init__() got an unexpected keyword argument 'name'

New behavior

no more parsing error when using the ros_topic_wait_for_topics action

How to test

@fmirus fmirus requested a review from fred-labs June 27, 2024 08:03
@fred-labs fred-labs enabled auto-merge (squash) June 27, 2024 08:04
Copy link

Test Results

198 tests   184 ✅  21m 52s ⏱️
 11 suites   14 💤
 11 files      0 ❌

Results for commit 815d5c3.

@fred-labs fred-labs merged commit 7356b31 into main Jun 27, 2024
23 checks passed
@fred-labs fred-labs deleted the bugfix_ros_wait_for_topics branch June 27, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants