Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow file_upload param to be present while creating and editing a link #10

Merged
merged 1 commit into from
Dec 8, 2015

Conversation

AnkurGel
Copy link
Contributor

@AnkurGel AnkurGel commented Dec 6, 2015

Hi
According to the python API docs for file upload while create, file_upload is listed as parameter to specify file path with. However, the api.py accepts upload_file as param.

Didn't update the README.md since file_upload_json is the actual parameter sent to api. As cover_image is the parameter for cover_image_json, so should file_upload for file_upload_json. I think. 😕

This PR patches an additional file_upload parameter, which if present overrides upload_file and continues the flow. upload_file remains present for backward compatibility.

ashwch added a commit that referenced this pull request Dec 8, 2015
Allow file_upload param to be present while creating and editing a link
@ashwch ashwch merged commit eaad65b into Instamojo:master Dec 8, 2015
@ashwch
Copy link
Contributor

ashwch commented Dec 8, 2015

@AnkurGel Thanks!

@AnkurGel
Copy link
Contributor Author

AnkurGel commented Dec 8, 2015

Awesome! Thanks @ashwch! Also, I originally wrote Instamojo-rb gem for v1. I was updating the library to v1.1 over the weekend. @hiway pointed to you. Can you have a look at AnkurGel/Instamojo-rb#2 too? If it looks all good, I can update the library on rubygems and you guys can update the listing.
You can reach me at ankurgel [at] gmail [dot] com.

@ashwch
Copy link
Contributor

ashwch commented Dec 9, 2015

@AnkurGel We have added 3 more endpoints related to refunds. It would be great if you can include them in your Ruby wrapper as well?

@AnkurGel AnkurGel deleted the link_create_fix branch December 9, 2015 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants