Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST v1.1 #2

Merged
merged 37 commits into from
Dec 18, 2015
Merged

REST v1.1 #2

merged 37 commits into from
Dec 18, 2015

Conversation

AnkurGel
Copy link
Owner

@AnkurGel AnkurGel commented Dec 6, 2015

Instamojo API has been updated to v1.1.
With the new API, several new features:

  • Optional parameter to provide dev auth_token to play around with API directly.
  • Offer terminology has been shifted to Link
  • Add file_upload and cover_image support in wrapper.
  • Payment API introduction:
    • List of payments
    • Requesting new payment
    • Details and status of payment(s)
  • Refund API introduction
    • List of refunds
    • Create a refund
    • Details of a refund
  • Endpoint for test api.
  • Update README
  • Publish on RubyGems

Development of following is being carried out in branch 1.1
Closing issue #1

@AnkurGel AnkurGel mentioned this pull request Dec 6, 2015
11 tasks
@AnkurGel
Copy link
Owner Author

AnkurGel commented Dec 9, 2015

@ashwch Updated with the refund API. Let me know if you require the bundled gem to test.

@ashwch
Copy link
Contributor

ashwch commented Dec 10, 2015

@AnkurGel Great! I have opened a PR against your 1.1 branch, after those changes it is good to go.

One more thing, if it is possible to make the base API URL an optional argument to Instamojo::API.new() then it would be useful for users to provide different URL on the fly. For example we also have https://test.instamojo.com/api/1.1 as well. The Python and PHP wrappers are already handling the same.

@AnkurGel
Copy link
Owner Author

Thanks @ashwch. Merged #3. Yes, adding an optional parameter to add test endpoint makes sense. I have pushed the support for that. Give it a shot, then we're set for release. 😄

@AnkurGel
Copy link
Owner Author

@ashwch - Hey. Merged #4. Cleaned up some code. Can you please check if it all works good for you for v1.1?

@AnkurGel AnkurGel mentioned this pull request Dec 12, 2015
@AnkurGel
Copy link
Owner Author

Also, according to documentation, a created refund can only be retrieved by /refunds/:refund_id. While this is good, it would be awesome to have this RESTful GET route on payments - /payments/:payment_id/refund, if possible. I just added #process_refund in Payment class which helps to instantaneously process refund for a given payment. Exposing that additional route will enable me to check and get the existing refund carried on that payment(payment.get_refund). // cc @ashwch

@AnkurGel
Copy link
Owner Author

bump! // cc @ashwch

@ashwch
Copy link
Contributor

ashwch commented Dec 17, 2015

@AnkurGel Apologies, been bust lately. Regarding payments/:payment_id/refund, it's a good point, but we won't be able to change the endpoints now.

I will try to test the new changes by EOD.

@AnkurGel
Copy link
Owner Author

Cool. No problem.

On Thu, Dec 17, 2015 at 12:20 PM, Ashwini Chaudhary <
[email protected]> wrote:

@AnkurGel https://github.com/AnkurGel Apologies, been bust lately.
Regarding payments/:payment_id/refund, it's a good point, but we won't be
able to change the endpoints now.

I will try to test the new changes by EOD.


Reply to this email directly or view it on GitHub
#2 (comment).

-Ankur Goel

@ashwch
Copy link
Contributor

ashwch commented Dec 17, 2015

@AnkurGel Added 2 comments. After those minor changes we can publish it on RubyGems. Big thanks !-)

AnkurGel added a commit that referenced this pull request Dec 18, 2015
@AnkurGel AnkurGel merged commit 920fee1 into master Dec 18, 2015
@AnkurGel
Copy link
Owner Author

@ashwch : Awesome. Thanks a lot for help and contribution! Fixed doc.
And here we go - https://rubygems.org/gems/Instamojo-rb.
If you'd like, you can keep a forked copy of this repo in Instamojo org and add the gem in supported libraries.
Spread the word :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants