Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MOB-12858]: Add passing SDK version to the native support #387

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

[MOB-12858]: Add passing SDK version to the native support #387

wants to merge 11 commits into from

Conversation

asamiz
Copy link
Contributor

@asamiz asamiz commented Sep 10, 2023 •
edited by jira bot
Loading

Description of the change

Add the support of passing the RN SDK version to the native SDK by sending it as a second parameter in setCurrentPlatform API.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

JIRA Ticket ID: MOB-12858

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

asamiz and others added 5 commits July 24, 2023 13:24
@asamiz
[MOB-12516] Fix zone mismatch issue (#376)
8f8aaa9 
* fix(initialization): fix zone mismatch issue in initialization code

* fix(initilization): fix the PR comments
@abdelhamid-f-nasser
[MOB-12700] Remove danger ruby package (#379)
3035850 
Remove danger ruby package to resolve dependabot git security vulnerability issue.
@asamiz @a7medev
[MOB-12513] Fix Mockito and Pigeon Dependency Conflict (#377)
ef14f74 
* Unrestrict a specific Pigeon version

* Unrestrict a specific Mockito version

* Upgrade Flutter CI version with Mockito and Pigeon

* Remove ask question button in example

---------

Co-authored-by: Ahmed Mahmoud <[email protected]>
@a7medev
test: update captain config (#386)
08f88b0 
Jira ID: MOB-13002
@asamiz
feat(sdkVersion): add passing SDK version to the native support
c6cfe37
@asamiz asamiz marked this pull request as draft September 11, 2023 00:00
@InstabugCI
Copy link
Collaborator

InstabugCI commented Sep 11, 2023 •
edited
Loading

Coverage Report

Label Coverage Status
Dart 83.7% ✅

Generated by 🚫 dangerJS against 4ac9260

Base automatically changed from dev to master September 14, 2023 13:20
@asamiz asamiz changed the base branch from master to dev September 17, 2023 08:22
Base automatically changed from dev to master September 19, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asamiz @InstabugCI @abdelhamid-f-nasser @a7medev