Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update captain config #386

Merged
merged 5 commits into from
Sep 10, 2023
Merged

test: update captain config #386

merged 5 commits into from
Sep 10, 2023

Conversation

a7medev
Copy link
Contributor

@a7medev a7medev commented Sep 7, 2023

Description of the change

Use the new Captain config to fix E2E tests issues especially on CI.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Jira ID: MOB-13002

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@a7medev a7medev self-assigned this Sep 7, 2023
@InstabugCI
Copy link
Collaborator

InstabugCI commented Sep 7, 2023

Coverage Report

Label Coverage Status
Dart 83.7%

Generated by 🚫 dangerJS against feeb2d6

Copy link
Contributor

@asamiz asamiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @a7medev, this is approval from my side

Copy link
Contributor

@abdelhamid-f-nasser abdelhamid-f-nasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great effort finding out why it was failing as always @a7medev 🚀, Keep up the good work 💪.

@a7medev a7medev merged commit 08f88b0 into dev Sep 10, 2023
@a7medev a7medev deleted the fix/captain-e2e branch September 10, 2023 11:55
ymabdallah pushed a commit that referenced this pull request Sep 14, 2023
* [MOB-12516] Fix zone mismatch issue (#376)

* fix(initialization): fix zone mismatch issue in initialization code

* fix(initilization): fix the PR comments

* [MOB-12700] Remove danger ruby package (#379)

Remove danger ruby package to resolve dependabot git security vulnerability issue.

* [MOB-12513] Fix Mockito and Pigeon Dependency Conflict (#377)

* Unrestrict a specific Pigeon version

* Unrestrict a specific Mockito version

* Upgrade Flutter CI version with Mockito and Pigeon

* Remove ask question button in example

---------

Co-authored-by: Ahmed Mahmoud <[email protected]>

* test: update captain config (#386)

Jira ID: MOB-13002

* chore(ios): bump sdk to 11.14.0 (#383)

Jira ID: MOB-12993

* feat: support network logs obfuscation (#380)

Jira ID: MOB-12523

* feat: support network logs omission (#382)

Jira ID: MOB-12524

* chore(android): bump sdk to 11.14.0 (#384)

Jira ID: MOB-12992

* feat: add new repro steps api (#388)

Jira ID: MOB-13005

* chore: update sdk version to v11.14.0 (#389)

Jira ID: MOB-13014

---------

Co-authored-by: Ahmed Sami <[email protected]>
Co-authored-by: Ahmed Mahmoud <[email protected]>
Co-authored-by: Ahmed Mahmoud <[email protected]>
HeshamMegid pushed a commit that referenced this pull request Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants