Updates for ITKv5.2 code cleanups ... ROUND1#15
Merged
hjmjohnson merged 7 commits intomasterfrom Feb 27, 2020
Merged
Conversation
dzenanz
approved these changes
Feb 19, 2020
hjmjohnson
force-pushed
the
ITKv5_1rc2
branch
from
3576189 to
56548ff
Compare
Member
|
I wonder if |
dzenanz
approved these changes
Feb 25, 2020
```
git filter-branch -f \
--tree-filter "~/ITK/Utilities/Maintenance/clang-format.bash --clang-format ~/Dashboard/src/ITK-clang11/clang-format-Linux --tracked" \
master..
```
hjmjohnson
force-pushed
the
ITKv5_1rc2
branch
2 times, most recently
from
3ceac89 to
57311be
Compare
dzenanz
approved these changes
Feb 26, 2020
This check replaces default bodies of special member functions with = default;. The explicitly defaulted function declarations enable more opportunities in optimization, because the compiler might treat explicitly defaulted functions as trivial. Additionally, the C++11 use of = default more clearly expreses the intent for the special member functions.
The mission of NumFOCUS is to promote open practices in research, data, and scientific computing. https://numfocus.org
hjmjohnson
force-pushed
the
ITKv5_1rc2
branch
from
6167868 to
70897c4
Compare
hjmjohnson
force-pushed
the
ITKv5_1rc2
branch
from
70897c4 to
f8f5e91
Compare
https://devblogs.microsoft.com/devops/removing-older-images-in-azure-pipelines-hosted-pools/ Use full paths simplifies debugging
hjmjohnson
force-pushed
the
ITKv5_1rc2
branch
from
b3ea932 to
3448cb1
Compare
thewtex
approved these changes
Feb 27, 2020
| EXPRESSION "instance = itk.PolarToCartesianTransform.New()") | ||
| itk_python_expression_add_test(NAME itkCartesianToPolarTransformPythonTest | ||
| EXPRESSION "instance = itk.CartesianToPolarTransform.New()") | ||
| if(ITK_WRAP_PYTHON) |
Member
There was a problem hiding this comment.
ITK 5 best practice is to put Python tests in wrapping/test/CMakeLists.txt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.