Skip to content

ENH: Updating remote module PolarTransform for new options#1659

Closed
romangrothausmann wants to merge 1 commit intoInsightSoftwareConsortium:masterfrom
romangrothausmann:extITKPolarTransform
Closed

ENH: Updating remote module PolarTransform for new options#1659
romangrothausmann wants to merge 1 commit intoInsightSoftwareConsortium:masterfrom
romangrothausmann:extITKPolarTransform

Conversation

@romangrothausmann
Copy link
Copy Markdown
Member

Make use of PR #14 of ITKPolarTransform: InsightSoftwareConsortium/ITKPolarTransform#14

@hjmjohnson hjmjohnson self-assigned this Feb 26, 2020
Copy link
Copy Markdown
Member

@hjmjohnson hjmjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is ongoing work with all the remote modules. I'd prefer to wait a bit and bunch these together in a larger PR to minimize noise in the pull requests for the 44 different modules. Additionally, there are outstatnding PR's for the PolarTransform that I am actively working through.

Of course if this change has a specific immediate need, then merge now.

@romangrothausmann
Copy link
Copy Markdown
Member Author

Sure, as you see fit. The PR can just serve as a reminder. I solved the use of the new additions by first pulling the new commits, which seems to work fine:

https://github.com/romangrothausmann/ITK-CLIs/blob/9a6170cc377f42e9273876480e4953a033d6df6d/Dockerfile#L22-L24

In addition, I think CartesianToPolarTransform and PolarToCartesianTransform or a Transform combining both deserve to be included in main ITK, as they represent the pendant to AzimuthElevationToCartesianTransform (i.e. cylindrical vs. spherical transform):
InsightSoftwareConsortium/ITKPolarTransform#15 (comment)

@hjmjohnson
Copy link
Copy Markdown
Member

superseded by #1671

@hjmjohnson hjmjohnson closed this Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants