Update itkNaryFunctorImageFilter#55
Closed
pierre33 wants to merge 1 commit intoInsightSoftwareConsortium:masterfrom
Closed
Update itkNaryFunctorImageFilter#55pierre33 wants to merge 1 commit intoInsightSoftwareConsortium:masterfrom
pierre33 wants to merge 1 commit intoInsightSoftwareConsortium:masterfrom
Conversation
In the context of my work, I need a itk::NaryFunctorImageFilter because I can have a different number of input images depending on the context. Specifically, I can have 1 to 3 input images. I realized that the filter itk::NaryFunctorImageFilter has a required number of inputs equal to 2 and I do not understand why. Above all, when I check the method DynamicThreadedGenerateData I see the following check: numberOfValidInputImages == 0 and I am wondering why it is not numberOfValidInputImages < 1. Therefore I suggest the following change by setting the number of required inputs to 1. Kind regards, Pierre Lassalle
Collaborator
|
Can one of the admins verify this patch? |
1 similar comment
Collaborator
|
Can one of the admins verify this patch? |
phcerdan
reviewed
Aug 24, 2018
Contributor
Member
|
Superseded in: #55 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the context of my work, I need a itk::NaryFunctorImageFilter because I can have a different number of input images depending on the context. Specifically, I can have 1 to 3 input images. I realized that the filter itk::NaryFunctorImageFilter has a required number of inputs equal to 2 and I do not understand why. Above all, when I check the method DynamicThreadedGenerateData I see the following check: numberOfValidInputImages == 0 and I am wondering why it is not numberOfValidInputImages < 2. Therefore I suggest the following change by setting the number of required inputs to 1.
Kind regards,
Pierre Lassalle
See the CONTRIBUTING guide. Specifically:
Start ITK commit messages with a standard prefix (and a space):
Provide a short, meaningful message that describes the change you made.
When the PR is based on a single commit, the commit message is usually left as the PR message.
A reference to a related issue or pull request in your repository. You can automatically close a related issues using keywords
@mentions of the person or team responsible for reviewing proposed changes.
Thanks for contributing to ITK!