ENH: Update itkNaryFunctorImageFilter#110
Merged
hjmjohnson merged 1 commit intoInsightSoftwareConsortium:masterfrom Nov 7, 2018
Merged
ENH: Update itkNaryFunctorImageFilter#110hjmjohnson merged 1 commit intoInsightSoftwareConsortium:masterfrom
hjmjohnson merged 1 commit intoInsightSoftwareConsortium:masterfrom
Conversation
There is a need for a itk::NaryFunctorImageFilter because a different number of input images may depend on the context. Specifically, one may have 1 to 3 input images. The filter itk::NaryFunctorImageFilter has a required number of inputs equal to 2 Above all, the method DynamicThreadedGenerateData with the following check: numberOfValidInputImages == 0 and I am wondering why it is not numberOfValidInputImages < 1. Therefore the suggested change is to set the number of required inputs to 1.
Member
Author
Member
Author
|
@phcerdan You previously made comments in the gerrit system. I have tried to address those issues when moved to Github. Please re-review the changes here. |
phcerdan
approved these changes
Nov 6, 2018
phcerdan
approved these changes
Nov 6, 2018
Contributor
|
Was this merged @hjmjohnson? |
Member
Author
|
Accidently deleted/closed branch when the script for moving from Gerrit went haywire. |
Contributor
|
Cool, this is ready to be merged IMO |
thewtex
approved these changes
Nov 6, 2018
Member
|
@pierre33 thanks for contributing. @phcerdan thanks for reviewing and shepherding. @hjmjohnson thanks for carrying through the GitHub update. 🥇 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.