ENH: Add pre-commit GitHub Action#5239
Merged
thewtex merged 6 commits intoInsightSoftwareConsortium:masterfrom Feb 13, 2025
Merged
ENH: Add pre-commit GitHub Action#5239thewtex merged 6 commits intoInsightSoftwareConsortium:masterfrom
thewtex merged 6 commits intoInsightSoftwareConsortium:masterfrom
Conversation
github-actions
bot
added
type:Infrastructure
dzenanz
approved these changes
Feb 11, 2025
thewtex
force-pushed
the
pre-commit-gh-action
branch
from
e859a3d to
f85e6a8
Compare
github-actions
bot
added
area:Core
thewtex
force-pushed
the
pre-commit-gh-action
branch
from
3b1825a to
9e06ec9
Compare
Run our pre-commit checks. The pre-commit GHA will install via `python -m pip`. Configure hooks.SetupForDevelopment for pre-commit GHA. Set to a high number to avoid local developer check. Also mock user.email, user.name for local hooks.
Found by pre-commit GitHub Action.
Applied via: pixi run pre-commit-run
Latest version.
thewtex
force-pushed
the
pre-commit-gh-action
branch
from
9e06ec9 to
8915e0e
Compare
N-Dekker
reviewed
Feb 12, 2025
dzenanz
reviewed
Feb 12, 2025
Member
dzenanz
left a comment
dzenanz
left a comment
There was a problem hiding this comment.
Maybe we should hold off the last 2 commits for now?
| { | ||
| return (includeCenterPixel ? 1 : 0) + CalculateNumberOfConnectedNeighbors(maximumCityblockDistance); | ||
| } | ||
|
|
N-Dekker
reviewed
Feb 12, 2025
Modules/Filtering/QuadEdgeMeshFiltering/include/itkQuadEdgeMeshDecimationCriteria.h
Show resolved
Hide resolved
Last available on mirrors-clang-format. The procedure described in InsightSoftwareConsortium@98f0ffa was followed to ensure no changes were required to the .clang-format configuration files.
clang-format 19.1.7 and pre-commit 4.1.0.
thewtex
force-pushed
the
pre-commit-gh-action
branch
from
8915e0e to
2659871
Compare
Member
Author
These are necessary to get the CI check green. |
dzenanz
approved these changes
Feb 12, 2025
hjmjohnson
approved these changes
Feb 12, 2025
jhlegarreta
approved these changes
Feb 12, 2025
Member
jhlegarreta
left a comment
jhlegarreta
left a comment
There was a problem hiding this comment.
Re: #5239 (comment). I've noticed that, but it looks like the changes in PR #3805 did not have the desired effect, or else, ther were more warnings that were raised after that:
https://open.cdash.org/viewBuildError.php?type=1&buildid=10204557
😔 We will need to revisit the unbalanced warnings issue. Approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run our pre-commit checks.