Skip to content

BUG: Use pip to install cmake for release #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
blowekamp wants to merge 1 commit into from
Closed

BUG: Use pip to install cmake for release #52

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,7 @@ jobs:
command: |
sudo apt-get install -y rsync ninja-build ccache
sudo pip install --upgrade pip
sudo pip install scikit-ci-addons
ci_addons circle/install_cmake.py 3.7.2
sudo pip install cmake==3.7.2 scikit-ci-addons
Copy link
Contributor

@jcfr jcfr Jul 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future reference, since rsync is already installed, having:

sudo pip install -U scikit-ci-addons
ci_addons circle/install_cmake.py 3.7.2

would also work now.

Copy link
Member Author

@blowekamp blowekamp Jul 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This broke in the 0.21.0 release. Is it expect to be fixed is a patch release?

- run:
name: CCache initialization
command: |
Expand Down