Skip to content

BUG: Use pip to install cmake for release#52

Closed
blowekamp wants to merge 1 commit intoInsightSoftwareConsortium:masterfrom
blowekamp:UsePipToInstallCMake-for-release-only
Closed

BUG: Use pip to install cmake for release#52
blowekamp wants to merge 1 commit intoInsightSoftwareConsortium:masterfrom
blowekamp:UsePipToInstallCMake-for-release-only

Conversation

@blowekamp
Copy link
Member

scikit-ci-addons intall_cmake explicitly fails with CircleCI
2.0. Revert to pip install cmake.

ref: scikit-build/scikit-ci-addons#69

scikit-ci-addons intall_cmake explicitly fails with CircleCI
2.0. Revert to `pip install cmake`.

Change-Id: Id5e30d53878b88be51e00fa40a927b3fa05fa5a9
@blowekamp blowekamp force-pushed the UsePipToInstallCMake-for-release-only branch from 605d13b to e8dfb0a Compare July 30, 2018 13:20
sudo pip install --upgrade pip
sudo pip install scikit-ci-addons
ci_addons circle/install_cmake.py 3.7.2
sudo pip install cmake==3.7.2 scikit-ci-addons
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future reference, since rsync is already installed, having:

sudo pip install -U scikit-ci-addons
ci_addons circle/install_cmake.py 3.7.2

would also work now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This broke in the 0.21.0 release. Is it expect to be fixed is a patch release?

@thewtex
Copy link
Member

thewtex commented Jul 31, 2018

This has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants