BUG: permissive cosine computation from non-orthogonal sform had reve… #4847
Commits on Sep 12, 2024
-
BUG: NIFTI "permissive" direction cosine error
Computation from non-orthogonal sform had reversed SVD components U and V were reversed in the reconstruction of M, according to definitions here https://vxl.github.io/doc/release/core/vnl/html/classvnl__svd.html
Commits on Sep 13, 2024
-
ENH: Test non-orthogonal NIFTI sform
Catches direction flip introduced by earlier SVD bug
Commits on Sep 16, 2024
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.