COMP: Fix unit tests for OpenCV 4#1591
Merged
thewtex merged 1 commit intoInsightSoftwareConsortium:masterfrom Feb 5, 2020
Merged
COMP: Fix unit tests for OpenCV 4#1591thewtex merged 1 commit intoInsightSoftwareConsortium:masterfrom
thewtex merged 1 commit intoInsightSoftwareConsortium:masterfrom
Conversation
1 task
nocnokneo
commented
Feb 4, 2020
dzenanz
approved these changes
Feb 4, 2020
Member
dzenanz
left a comment
dzenanz
left a comment
There was a problem hiding this comment.
I didn't try compiling or running, but it looks like an improvement.
hjmjohnson
added a commit
to hjmjohnson/ITK
that referenced
this pull request
Feb 12, 2020
CHANGED:
- AreaType to AreaEnum enum class
- ConnectivityEnumType to ConnectivityEnum enum class
- EdgeStatusType to EdgeStatusEnum enum class
- GradientType to GradientEnum enum class
- GrowthStrategyType to GrowthStrategyEnum enum class
- GrowthStrategyType to GrowthStrategyEnum enum object
- HashFunction to HashFunctionEnum enum class
- Include Legacy_Remove parameters for backwards
- InterpolationMethodType to InterpolationMethodEnum enum class
- InterpolationModeType into InterpolationModeEnum enum class
- LabelType to LabelEnum enum class
- LeafIdentifier to LeafIdentifierEnum enum class
- LineSearchMethod to LineSearchMethodEnum
- LogLevel to LogLevelEnum enum class
- MetricCategoryType to MetricCategoryEnum enum class
- MetricSamplingStrategyType to MetricSamplingStrategyEnum
- NoiseModelType to NoiseModelEnum enum object
- OctreePlaneType to OctreePlaneEnum enum class
- OctreePlaneType to OctreePlaneNode enum object
- RegionType to RegionEnum enum class
- SIDE to SIDEEnum enum class
- SigmaStepMethodType to SigmanStepMethodEnum enum class
- Sign to SignEnum enum class
- StopConditionEnum to scoped enum class
- TERMINATION_CODE to TERMINATION_CODE_ENUM enum class
- TargetConditionType to TargetConditionEnum enum class
- TemporalUnitType to TemporalUnitEnum enum class
- TimeStampFormatType to TimeStampFormatEnum enum class
- TopologyCheckType to TopologyCheckEnum enum class
- TransformDirectionType to TransformDirectionEnum enum class
- TraversalDirection to TraversalDirectionEnum enum class
- WeightType to WeightEnum enum object
- ConnectedThresholdImageFilterEnums/ -> ConnectivityEnum
- QuadEdgeMeshEulerOperatorFlipEdgeFunctionEnums/EdgeStatusType -> EdgeStatusEnum
- ObjectStoreEnums/GrowthStrategy -> GrowthStrategyEnum
- HashImageFilterEnums/HashFunction -> HashFunctionEnum
- CommonEnums
+ IOPixel -> IOPixelEnum
+ IOComponent -> IOComponentEnum
+ IOFile -> IOFileEnum
+ IOFileMode -> IOFileModeEnum
+ IOByteOrder -> IOByteOrderEnum
+ CellGeometry -> CellGeometryEnum
- MeshEnums
+ MeshClassCellsAllocationMethod -> MeshClassCellsAllocationMethod
- ContourSpatialObjectEnums/InterpolationMethod -> InterpolationMethodEnum
- GaussianDerivateOperatorEnums/InterpolationMode -> InterpolationModeEnum
- OctreeNodeEnums/LeafIdentifier -> LeafIdentifierEnum
- LBFGS2Optimizerv4/LineSearchMethod -> LineSearchMethodEnum
- DCMTKImageIOEnums/LogLevel -> LogLevelEnum
- OctreeBaseEnums/Octree -> OctreeBaseEnums
- RegionEnums/RegionEnum -> RegionEnum
- FastMarchingTraitsEnum/TopologyCheck -> TopologyCheckEnum
- LoggerBaseEnums/(PriorityLevel & TimeStampFormat) -> PriorityLevelEnum & TimeStampFormatEnum
- TemporalDataObjectEnums/TemporalUnit -> TemporalUnitEnum
- ComplexToComplexFFTImageFilterEnums/TransformDirection -> TransformDirectionEnum
- ScalarToRGBColormapImageFilterEnums/RGBColormapFilter -> RGBColormapFilterEnum
- FRPROptimizerEnums/Optimization -> Optimization
- TreeIteratorBaseEnums/TreeIteratorBaseNode -> NodeType (NO TEST NEED NEW TEST)
- FloatingPointExceptionsEnums/ExceptionAction -> ExceptionActionEnum
- VideoIOFactoryEnums/IOMode -> IOModeEnum
- FastMarchingreachedTargetNoesStoppingCriterionEnums/TargetCondition -> TargetConditionEnum
- ObjectFactoryBaseEnums/InsertionPosition-> InsertionPositionEnums
- HistogramToRunLengthFeaturesFilterEnums/RunLengthFeature -> RunLengthFeatureEnum
- MultiThreaderBaseEnums/ThreadExitCode -> ThreadExitCodeEnum
- MultiThreaderBaseEnums/Threader -> ThreadEnum
- DTITibeSpatialObjectPointenums/DTITubeSpatialObjectPointField -> DTITubeSpatialObjectPointFieldEnum
- ConvolutionImageFilterBaseEnums/ConvolutionImageFilterOutput -> ConvolutionImageFilterOutputEnum
- ExtractSliceImageFilterEnums/TestExtractSliceImageFilterCollapseStrategy -> TestExtractSliceImageFilterCollapseStrategyEnum
- PatchBasedDenoisingBaseImageFilterEnums/
+ NoiseModel -> NoiseModelEnum
+ ComponentSpace -> ComponentSpaceEnum
+ FilterState -> FilterStateEnum
- DiffusionTensor3DReconstructionImageFilterEnums/GradientImageFormat -> GradientImageFormatEnum
- GDCMImageIOEnums/Compression -> CompressionEnums
- FastMarchingImageFilterEnums/Label -> LabelEnums
- VideoIOBaseEnums/ReadFrom -> ReadFromEnum
- ConnectThresholdImageFilterEnums/Connectivity -> ConnectivityEnum
- DeformableSimplexMesh3DGradientConstraintForceFilter/SIDE -> SIDEEnum
- ImageRegistrationMethodv4Enums/MetricSamplingStrategy -> MetricSamplingStrategyEnum
- TransformBaseTemplateEnums/TransformCategory -> TransformCategoryEnums
- MergeLabelMapFilterEnums/ChoiceMethod -> ChoiceMethodEnum
- LaplacianDeformationQuadEdgeMeshFilterEnums/Area -> AreaEnum
- IOCommonEnums/AtomicPixel -> AtomicPixelEnum
- ESMDemonsRegistrationFunctionEnums/Gradient -> GradientEnum
- RecursiveGaussianImageFilterEnums/GaussianOrder -> GaussianOrderEnum
- SPSAOptimizerEnums/StopConditionSPSAOptimizer -> StopConditionSPSAOptimizerEnum
- SymmetricEigenAnalysisEnums/EigenValueOrder -> EigenValueOrderEnum
- ObjectToObjectMetricBaseTemplateEnums
+ GradientSource -> GradientSourceEnums
+ MetricCategory -> MetricCategoryEnums
- ObjectToObjectOptimizerBaseTemplateEnums/StopConditionObjectToObjectOptimizer -> StopConditionObjectToObjectOptimizerEnum
- RegistrationParameterScalesEstimatorEnums/SamplingStrategy -> SamplingStrategyEnum
- HistogramToTextureFeaturesFilterEnums/TextureFeature -> TextureFeatureEnum
- RayCasterHelperEnums/TraversalDirection -> TraversalDirectionEnum
- CallRecordEnums/
+ RecordType -> RecoredEnum
+ MethodType -> MethodEnum
- JPEG2000ImageIOInternalEnums/
+ DecodingFormat -> DecodingFormatEnum
+ DFMFormat -> DFMFormaType
- FEMRegistrationFilterEnums/Sign -> SignEnum
CREATION:
- new enum class ExceptionEnum
- ExceptionActionEnum enum object
- MetricSamplingStrategyEnum enum class (scoped)
- Replace old static_cast with new itkExposeEnumValue to faciliate
future refactorings
NEW NAMES: These enums have been consolidated so only one
definition exists across the toolkit
- Image/Mesh/Transform versions of FileEnum|FileModeEnum|ByteOrderEnum
are now named IO(FileEnum|FileModeEnum|ByteOrderEnum) in itk namespace
- CellGeometryEnum is moved to itk namespace to remove exact duplicate
definitions in multiple modules (IO/Quadedgemesh/...)
NEW FILE:
EnumPrintFunction.py - creates a basic template of an ITKv5 enum class
Change some duplicate enum class names that have different values so
that they are uniquely named for their intended purpose.
Co-Authored by: Mathew J. Seng <mathewseng@gmail.com>
Co-Authored by: Matt McCormick <matt.mccormick@kitware.com>
Co-Authored by: Hans Johnson <hans-johnson@uiowa.edu>
commit d8879be
Author: Hans Johnson <hans-johnson@uiowa.edu>
Date: Tue Feb 11 17:18:12 2020
COMP: Need to explicitly define std::min<> template values
commit afacde6
Author: Hans Johnson <hans-johnson@uiowa.edu>
Date: Tue Dec 31 11:47:42 2019
STYLE: clang-format style updates.
commit 198a800
Author: Hans Johnson <hans-johnson@uiowa.edu>
Date: Sat Feb 8 11:57:15 2020
ENH: Update RTK for future proofing.
Using explicit typecasts for futuree proofing
enums. RTK treats enum values as integers and
eneumerations interchangibly for pushing onto
a stack of integers. Using explicit static_casts
makes code future proof when enum class is used.
commit 486d3e8 (upstream/python-builds, upstream/nightly-master, upstream/master)
Merge: aa4e759 f0dde80
Author: Matt McCormick <matt.mccormick@kitware.com>
Date: Tue Feb 11 15:50:36 2020
Merge pull request InsightSoftwareConsortium#1604 from thewtex/contributor-welcome
DOC: Add welcome message to CONTRIBUTING.md
commit f0dde80
Author: Matt McCormick <matt.mccormick@kitware.com>
Date: Tue Feb 11 14:49:46 2020
DOC: Add welcome message to CONTRIBUTING.md
Scraped from https://github.com/nipy/nibabel/blob/master/.github/CONTRIBUTING.md
commit aa4e759
Merge: 102c3ed 344e9bc
Author: Matt McCormick <matt.mccormick@kitware.com>
Date: Tue Feb 11 12:07:27 2020
Merge pull request InsightSoftwareConsortium#1598 from thewtex/numfocus-copyright
DOC: Update copyright assignment to NumFOCUS
commit 102c3ed
Author: Dženan Zukić <dzenan.zukic@kitware.com>
Date: Mon Feb 10 10:41:11 2020
BUG: remove assertion which frequently fails
We are not checking difference along dimension zero,
so it is possible for diffSum to be 0 despite neighbors being different.
This is a follow-up to c32a784.
commit 3f232f7
Author: Hans Johnson <hans-johnson@uiowa.edu>
Date: Sat Feb 8 13:27:29 2020
BUG: operator() can not be const
The member variable is changed, so the operator() can not be const.
commit 94769e0 (origin/master, origin/HEAD)
Author: Vladimir S. FONOV <vladimir.fonov@gmail.com>
Date: Mon Feb 3 13:33:14 2020
DOC: updated ITK5MigrationGuide on Analyze format support
commit 14851ac
Author: Bradley Lowekamp <blowekamp@mail.nih.gov>
Date: Fri Feb 7 10:25:29 2020
BUG: Restore enum typedef name Convolution and Deconvolution filters
commit da0e395
Merge: abcd10b 305fc77
Author: Matt McCormick <matt.mccormick@kitware.com>
Date: Fri Feb 7 14:02:00 2020
Merge pull request InsightSoftwareConsortium#1596 from DVigneault/BumpCuberilleCommitHash
BUG: Bump Cuberille Commit Hash
commit 344e9bc (thewtex/numfocus-copyright)
Author: Matt McCormick <matt.mccormick@kitware.com>
Date: Fri Feb 7 13:23:51 2020
DOC: Update copyright assignment to NumFOCUS
As part of the process of the Insight Software Consortium joining the
NumFOCUS non-profit corporation as a Fiscally Sponsored Project, all
assets, including intellectual property assets, are being transferred to
enable dissolution of the Insight Software Consortium non-profit
corporate legal entity.
The Insight Software Consortium Board of Directors resolved in the
2019-10-22 Meeting to assign ITK copyright to NumFOCUS and CMake and
IGSTK to Kitware. A copy of the signed copyright transfer documents is
attached to this pull request.
commit 305fc77
Author: Davis Vigneault <davis.vigneault@gmail.com>
Date: Fri Feb 7 12:38:06 2020
BUG: Bump Cuberille Commit Hash
Recent patches to ITKCuberille have addressed a longstanding issue
which caused failures when generating itk::QuadEdgeMesh objects.
This commit updates the git commit hash, bringing this bugfix into
the master branch if ITK.
commit abcd10b
Merge: e138b60 f93f025
Author: Matt McCormick <matt.mccormick@kitware.com>
Date: Fri Feb 7 12:42:31 2020
Merge pull request InsightSoftwareConsortium#1594 from thewtex/readme-citation-section
DOC: Add Citation section to README
commit f93f025
Author: Matt McCormick <matt.mccormick@kitware.com>
Date: Thu Feb 6 15:38:21 2020
DOC: Request updates ITKBibliography.bib
commit d362bc0
Author: Matt McCormick <matt.mccormick@kitware.com>
Date: Thu Feb 6 15:23:55 2020
DOC: Add Citation section to README
Closes InsightSoftwareConsortium#456
commit e138b60 (thewtex/master)
Merge: c32a784 5d1ba7f
Author: Matt McCormick <matt.mccormick@kitware.com>
Date: Tue Feb 4 18:33:12 2020
Merge pull request InsightSoftwareConsortium#1591 from nocnokneo/OpenCV4
COMP: Fix unit tests for OpenCV 4
commit c32a784
Author: Dženan Zukić <dzenan.zukic@kitware.com>
Date: Mon Feb 3 11:04:15 2020
BUG: incorrect neighbor determination in scan-line derived filters
Thanks to @DVigneault for finding the bug and creating a MWE to demonstrate it
commit 5671480
Merge: e0262df cb2bec6
Author: Matt McCormick <matt.mccormick@kitware.com>
Date: Mon Feb 3 15:46:51 2020
Merge pull request InsightSoftwareConsortium#1582 from thewtex/itk-python-filter-downcast
BUG: Call itk.down_cast on ProcessObject outputs in functional call
hjmjohnson
added a commit
to thewtex/ITK
that referenced
this pull request
Feb 12, 2020
CHANGED:
- AreaType to AreaEnum enum class
- ConnectivityEnumType to ConnectivityEnum enum class
- EdgeStatusType to EdgeStatusEnum enum class
- GradientType to GradientEnum enum class
- GrowthStrategyType to GrowthStrategyEnum enum class
- GrowthStrategyType to GrowthStrategyEnum enum object
- HashFunction to HashFunctionEnum enum class
- Include Legacy_Remove parameters for backwards
- InterpolationMethodType to InterpolationMethodEnum enum class
- InterpolationModeType into InterpolationModeEnum enum class
- LabelType to LabelEnum enum class
- LeafIdentifier to LeafIdentifierEnum enum class
- LineSearchMethod to LineSearchMethodEnum
- LogLevel to LogLevelEnum enum class
- MetricCategoryType to MetricCategoryEnum enum class
- MetricSamplingStrategyType to MetricSamplingStrategyEnum
- NoiseModelType to NoiseModelEnum enum object
- OctreePlaneType to OctreePlaneEnum enum class
- OctreePlaneType to OctreePlaneNode enum object
- RegionType to RegionEnum enum class
- SIDE to SIDEEnum enum class
- SigmaStepMethodType to SigmanStepMethodEnum enum class
- Sign to SignEnum enum class
- StopConditionEnum to scoped enum class
- TERMINATION_CODE to TERMINATION_CODE_ENUM enum class
- TargetConditionType to TargetConditionEnum enum class
- TemporalUnitType to TemporalUnitEnum enum class
- TimeStampFormatType to TimeStampFormatEnum enum class
- TopologyCheckType to TopologyCheckEnum enum class
- TransformDirectionType to TransformDirectionEnum enum class
- TraversalDirection to TraversalDirectionEnum enum class
- WeightType to WeightEnum enum object
- ConnectedThresholdImageFilterEnums/ -> ConnectivityEnum
- QuadEdgeMeshEulerOperatorFlipEdgeFunctionEnums/EdgeStatusType -> EdgeStatusEnum
- ObjectStoreEnums/GrowthStrategy -> GrowthStrategyEnum
- HashImageFilterEnums/HashFunction -> HashFunctionEnum
- CommonEnums
+ IOPixel -> IOPixelEnum
+ IOComponent -> IOComponentEnum
+ IOFile -> IOFileEnum
+ IOFileMode -> IOFileModeEnum
+ IOByteOrder -> IOByteOrderEnum
+ CellGeometry -> CellGeometryEnum
- MeshEnums
+ MeshClassCellsAllocationMethod -> MeshClassCellsAllocationMethod
- ContourSpatialObjectEnums/InterpolationMethod -> InterpolationMethodEnum
- GaussianDerivateOperatorEnums/InterpolationMode -> InterpolationModeEnum
- OctreeNodeEnums/LeafIdentifier -> LeafIdentifierEnum
- LBFGS2Optimizerv4/LineSearchMethod -> LineSearchMethodEnum
- DCMTKImageIOEnums/LogLevel -> LogLevelEnum
- OctreeBaseEnums/Octree -> OctreeBaseEnums
- RegionEnums/RegionEnum -> RegionEnum
- FastMarchingTraitsEnum/TopologyCheck -> TopologyCheckEnum
- LoggerBaseEnums/(PriorityLevel & TimeStampFormat) -> PriorityLevelEnum & TimeStampFormatEnum
- TemporalDataObjectEnums/TemporalUnit -> TemporalUnitEnum
- ComplexToComplexFFTImageFilterEnums/TransformDirection -> TransformDirectionEnum
- ScalarToRGBColormapImageFilterEnums/RGBColormapFilter -> RGBColormapFilterEnum
- FRPROptimizerEnums/Optimization -> Optimization
- TreeIteratorBaseEnums/TreeIteratorBaseNode -> NodeType (NO TEST NEED NEW TEST)
- FloatingPointExceptionsEnums/ExceptionAction -> ExceptionActionEnum
- VideoIOFactoryEnums/IOMode -> IOModeEnum
- FastMarchingreachedTargetNoesStoppingCriterionEnums/TargetCondition -> TargetConditionEnum
- ObjectFactoryBaseEnums/InsertionPosition-> InsertionPositionEnums
- HistogramToRunLengthFeaturesFilterEnums/RunLengthFeature -> RunLengthFeatureEnum
- MultiThreaderBaseEnums/ThreadExitCode -> ThreadExitCodeEnum
- MultiThreaderBaseEnums/Threader -> ThreadEnum
- DTITibeSpatialObjectPointenums/DTITubeSpatialObjectPointField -> DTITubeSpatialObjectPointFieldEnum
- ConvolutionImageFilterBaseEnums/ConvolutionImageFilterOutput -> ConvolutionImageFilterOutputEnum
- ExtractSliceImageFilterEnums/TestExtractSliceImageFilterCollapseStrategy -> TestExtractSliceImageFilterCollapseStrategyEnum
- PatchBasedDenoisingBaseImageFilterEnums/
+ NoiseModel -> NoiseModelEnum
+ ComponentSpace -> ComponentSpaceEnum
+ FilterState -> FilterStateEnum
- DiffusionTensor3DReconstructionImageFilterEnums/GradientImageFormat -> GradientImageFormatEnum
- GDCMImageIOEnums/Compression -> CompressionEnums
- FastMarchingImageFilterEnums/Label -> LabelEnums
- VideoIOBaseEnums/ReadFrom -> ReadFromEnum
- ConnectThresholdImageFilterEnums/Connectivity -> ConnectivityEnum
- DeformableSimplexMesh3DGradientConstraintForceFilter/SIDE -> SIDEEnum
- ImageRegistrationMethodv4Enums/MetricSamplingStrategy -> MetricSamplingStrategyEnum
- TransformBaseTemplateEnums/TransformCategory -> TransformCategoryEnums
- MergeLabelMapFilterEnums/ChoiceMethod -> ChoiceMethodEnum
- LaplacianDeformationQuadEdgeMeshFilterEnums/Area -> AreaEnum
- IOCommonEnums/AtomicPixel -> AtomicPixelEnum
- ESMDemonsRegistrationFunctionEnums/Gradient -> GradientEnum
- RecursiveGaussianImageFilterEnums/GaussianOrder -> GaussianOrderEnum
- SPSAOptimizerEnums/StopConditionSPSAOptimizer -> StopConditionSPSAOptimizerEnum
- SymmetricEigenAnalysisEnums/EigenValueOrder -> EigenValueOrderEnum
- ObjectToObjectMetricBaseTemplateEnums
+ GradientSource -> GradientSourceEnums
+ MetricCategory -> MetricCategoryEnums
- ObjectToObjectOptimizerBaseTemplateEnums/StopConditionObjectToObjectOptimizer -> StopConditionObjectToObjectOptimizerEnum
- RegistrationParameterScalesEstimatorEnums/SamplingStrategy -> SamplingStrategyEnum
- HistogramToTextureFeaturesFilterEnums/TextureFeature -> TextureFeatureEnum
- RayCasterHelperEnums/TraversalDirection -> TraversalDirectionEnum
- CallRecordEnums/
+ RecordType -> RecoredEnum
+ MethodType -> MethodEnum
- JPEG2000ImageIOInternalEnums/
+ DecodingFormat -> DecodingFormatEnum
+ DFMFormat -> DFMFormaType
- FEMRegistrationFilterEnums/Sign -> SignEnum
CREATION:
- new enum class ExceptionEnum
- ExceptionActionEnum enum object
- MetricSamplingStrategyEnum enum class (scoped)
- Replace old static_cast with new itkExposeEnumValue to faciliate
future refactorings
NEW NAMES: These enums have been consolidated so only one
definition exists across the toolkit
- Image/Mesh/Transform versions of FileEnum|FileModeEnum|ByteOrderEnum
are now named IO(FileEnum|FileModeEnum|ByteOrderEnum) in itk namespace
- CellGeometryEnum is moved to itk namespace to remove exact duplicate
definitions in multiple modules (IO/Quadedgemesh/...)
NEW FILE:
EnumPrintFunction.py - creates a basic template of an ITKv5 enum class
Change some duplicate enum class names that have different values so
that they are uniquely named for their intended purpose.
Co-Authored by: Mathew J. Seng <mathewseng@gmail.com>
Co-Authored by: Matt McCormick <matt.mccormick@kitware.com>
Co-Authored by: Hans Johnson <hans-johnson@uiowa.edu>
commit d8879be
Author: Hans Johnson <hans-johnson@uiowa.edu>
Date: Tue Feb 11 17:18:12 2020
COMP: Need to explicitly define std::min<> template values
commit afacde6
Author: Hans Johnson <hans-johnson@uiowa.edu>
Date: Tue Dec 31 11:47:42 2019
STYLE: clang-format style updates.
commit 198a800
Author: Hans Johnson <hans-johnson@uiowa.edu>
Date: Sat Feb 8 11:57:15 2020
ENH: Update RTK for future proofing.
Using explicit typecasts for futuree proofing
enums. RTK treats enum values as integers and
eneumerations interchangibly for pushing onto
a stack of integers. Using explicit static_casts
makes code future proof when enum class is used.
commit 486d3e8 (upstream/python-builds, upstream/nightly-master, upstream/master)
Merge: aa4e759 f0dde80
Author: Matt McCormick <matt.mccormick@kitware.com>
Date: Tue Feb 11 15:50:36 2020
Merge pull request InsightSoftwareConsortium#1604 from thewtex/contributor-welcome
DOC: Add welcome message to CONTRIBUTING.md
commit f0dde80
Author: Matt McCormick <matt.mccormick@kitware.com>
Date: Tue Feb 11 14:49:46 2020
DOC: Add welcome message to CONTRIBUTING.md
Scraped from https://github.com/nipy/nibabel/blob/master/.github/CONTRIBUTING.md
commit aa4e759
Merge: 102c3ed 344e9bc
Author: Matt McCormick <matt.mccormick@kitware.com>
Date: Tue Feb 11 12:07:27 2020
Merge pull request InsightSoftwareConsortium#1598 from thewtex/numfocus-copyright
DOC: Update copyright assignment to NumFOCUS
commit 102c3ed
Author: Dženan Zukić <dzenan.zukic@kitware.com>
Date: Mon Feb 10 10:41:11 2020
BUG: remove assertion which frequently fails
We are not checking difference along dimension zero,
so it is possible for diffSum to be 0 despite neighbors being different.
This is a follow-up to c32a784.
commit 3f232f7
Author: Hans Johnson <hans-johnson@uiowa.edu>
Date: Sat Feb 8 13:27:29 2020
BUG: operator() can not be const
The member variable is changed, so the operator() can not be const.
commit 94769e0 (origin/master, origin/HEAD)
Author: Vladimir S. FONOV <vladimir.fonov@gmail.com>
Date: Mon Feb 3 13:33:14 2020
DOC: updated ITK5MigrationGuide on Analyze format support
commit 14851ac
Author: Bradley Lowekamp <blowekamp@mail.nih.gov>
Date: Fri Feb 7 10:25:29 2020
BUG: Restore enum typedef name Convolution and Deconvolution filters
commit da0e395
Merge: abcd10b 305fc77
Author: Matt McCormick <matt.mccormick@kitware.com>
Date: Fri Feb 7 14:02:00 2020
Merge pull request InsightSoftwareConsortium#1596 from DVigneault/BumpCuberilleCommitHash
BUG: Bump Cuberille Commit Hash
commit 344e9bc (thewtex/numfocus-copyright)
Author: Matt McCormick <matt.mccormick@kitware.com>
Date: Fri Feb 7 13:23:51 2020
DOC: Update copyright assignment to NumFOCUS
As part of the process of the Insight Software Consortium joining the
NumFOCUS non-profit corporation as a Fiscally Sponsored Project, all
assets, including intellectual property assets, are being transferred to
enable dissolution of the Insight Software Consortium non-profit
corporate legal entity.
The Insight Software Consortium Board of Directors resolved in the
2019-10-22 Meeting to assign ITK copyright to NumFOCUS and CMake and
IGSTK to Kitware. A copy of the signed copyright transfer documents is
attached to this pull request.
commit 305fc77
Author: Davis Vigneault <davis.vigneault@gmail.com>
Date: Fri Feb 7 12:38:06 2020
BUG: Bump Cuberille Commit Hash
Recent patches to ITKCuberille have addressed a longstanding issue
which caused failures when generating itk::QuadEdgeMesh objects.
This commit updates the git commit hash, bringing this bugfix into
the master branch if ITK.
commit abcd10b
Merge: e138b60 f93f025
Author: Matt McCormick <matt.mccormick@kitware.com>
Date: Fri Feb 7 12:42:31 2020
Merge pull request InsightSoftwareConsortium#1594 from thewtex/readme-citation-section
DOC: Add Citation section to README
commit f93f025
Author: Matt McCormick <matt.mccormick@kitware.com>
Date: Thu Feb 6 15:38:21 2020
DOC: Request updates ITKBibliography.bib
commit d362bc0
Author: Matt McCormick <matt.mccormick@kitware.com>
Date: Thu Feb 6 15:23:55 2020
DOC: Add Citation section to README
Closes InsightSoftwareConsortium#456
commit e138b60 (thewtex/master)
Merge: c32a784 5d1ba7f
Author: Matt McCormick <matt.mccormick@kitware.com>
Date: Tue Feb 4 18:33:12 2020
Merge pull request InsightSoftwareConsortium#1591 from nocnokneo/OpenCV4
COMP: Fix unit tests for OpenCV 4
commit c32a784
Author: Dženan Zukić <dzenan.zukic@kitware.com>
Date: Mon Feb 3 11:04:15 2020
BUG: incorrect neighbor determination in scan-line derived filters
Thanks to @DVigneault for finding the bug and creating a MWE to demonstrate it
commit 5671480
Merge: e0262df cb2bec6
Author: Matt McCormick <matt.mccormick@kitware.com>
Date: Mon Feb 3 15:46:51 2020
Merge pull request InsightSoftwareConsortium#1582 from thewtex/itk-python-filter-downcast
BUG: Call itk.down_cast on ProcessObject outputs in functional call
hjmjohnson
added a commit
that referenced
this pull request
Sep 21, 2025
Closed issues: CMake configure warning with CMake 3.30 and newer #1579 Merged pull requests: pkgconfig: drop unused libraries from Libs.private #1591 (bgilbert) Fix CMake warning: Compatibility with CMake < 3.10 will be removed #1580 (dzenanz) code documentation updates #1576 (weanti) Fixed ICC profile copy failure on write #1574 (mircomir) opj_jp2_read_header: Check for error after parsing header. #1573 (sebras) (CVE-2025-54874)
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #806
PR Checklist