WIP: ENH: Wrap CastImageFilter for VectorImage <-> Vector#1579
WIP: ENH: Wrap CastImageFilter for VectorImage <-> Vector#1579thewtex wants to merge 1 commit intoInsightSoftwareConsortium:masterfrom
Conversation
| @@ -152,7 +153,7 @@ CastImageFilter<TInputImage, TOutputImage>::DynamicThreadedGenerateDataDispatche | |||
| { | |||
| const InputPixelType & inputPixel = inputIt.Get(); | |||
| OutputPixelType value; | |||
There was a problem hiding this comment.
This will not get set to the correct length for vector pixels.
There was a problem hiding this comment.
Outside the loops add something like:
OutputPixelType value;
NumericTraits<OutputPixelType>::SetLength(value, componentsPerPixels)
I'm not sure if its a NumericTraits or some other pixel traits class that is needed to set the number components correctly for all types OK.
Pulling it outside the loop also removes per-pixel allocation which is a performance killer.
There was a problem hiding this comment.
@blowekamp thanks for the note.
@Leengit it looks this addition was missed when with #2073 -- could you please add it in a follow-up patch?
|
This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions. |
stale
bot
added
the
status:Use_Milestone_Backlog
thewtex
removed
the
status:Use_Milestone_Backlog
|
This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions. |
stale
bot
added
the
status:Use_Milestone_Backlog
Closed issues: CMake configure warning with CMake 3.30 and newer #1579 Merged pull requests: pkgconfig: drop unused libraries from Libs.private #1591 (bgilbert) Fix CMake warning: Compatibility with CMake < 3.10 will be removed #1580 (dzenanz) code documentation updates #1576 (weanti) Fixed ICC profile copy failure on write #1574 (mircomir) opj_jp2_read_header: Check for error after parsing header. #1573 (sebras) (CVE-2025-54874)
2 participants
Addresses #1133