-
Notifications
You must be signed in to change notification settings - Fork 988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: hardware security module's support #2671
Conversation
7a98ca6
to
5e3dc52
Compare
5bae694
to
998ba80
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending: Application testing and need to read about HSM slot mechanism more
154dd70
to
f8f7b73
Compare
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
14456465 | Triggered | Generic High Entropy Secret | 395b3d9 | backend/src/ee/services/hsm/hsm-service.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
7f5d7ec
to
603fcd8
Compare
f22a558
Description 📣
This PR introduces hardware security module's support. It works as wrapper around any PKCS11 library, and allows for more secure cryptographic operations such as encryption, decryption, and randomness generation.
The implementation uses a key-wrapping mechanism, so it never directly uses the HSM primary encryption key.
Currently it supports recovery, but we need to iron out if this is actually behavior we want to allow. cc @maidul98
Type ✨
Tests 🛠️
# Here's some code block to paste some code snippets