Skip to content

Commit

Permalink
requested changes
Browse files Browse the repository at this point in the history
  • Loading branch information
DanielHougaard committed Nov 5, 2024
1 parent 604a03c commit f8f7b73
Show file tree
Hide file tree
Showing 11 changed files with 12 additions and 11 deletions.
2 changes: 1 addition & 1 deletion backend/e2e-test/vitest-environment-knex.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import { initDbConnection } from "@app/db";
import { queueServiceFactory } from "@app/queue";
import { keyStoreFactory } from "@app/keystore/keystore";
import { Redis } from "ioredis";
import { initializeHsmModule } from "@app/services/hsm/hsm-fns";
import { initializeHsmModule } from "@app/ee/services/hsm/hsm-fns";

dotenv.config({ path: path.join(__dirname, "../../.env.test"), debug: true });
export default {
Expand Down
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ export const hsmServiceFactory = ({ hsmModule: { module, graphene } }: THsmServi
const appCfg = getConfig();

// Constants for buffer structure
const IV_LENGTH = 16;
const IV_LENGTH = 12;
const TAG_LENGTH = 16;

const $findMasterKey = (session: grapheneLib.Session) => {
Expand Down
File renamed without changes.
3 changes: 2 additions & 1 deletion backend/src/main.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import dotenv from "dotenv";
import path from "path";

import { initializeHsmModule } from "@app/ee/services/hsm/hsm-fns";

import { initAuditLogDbConnection, initDbConnection } from "./db";
import { keyStoreFactory } from "./keystore/keystore";
import { formatSmtpConfig, initEnvConfig, IS_PACKAGED } from "./lib/config/env";
Expand All @@ -9,7 +11,6 @@ import { initLogger } from "./lib/logger";
import { queueServiceFactory } from "./queue";
import { main } from "./server/app";
import { bootstrapCheck } from "./server/boot-strap-check";
import { initializeHsmModule } from "./services/hsm/hsm-fns";
import { smtpServiceFactory } from "./services/smtp/smtp-service";

dotenv.config();
Expand Down
2 changes: 1 addition & 1 deletion backend/src/server/app.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ import fastify from "fastify";
import { Knex } from "knex";
import { Logger } from "pino";

import { HsmModule } from "@app/ee/services/hsm/hsm-types";
import { TKeyStoreFactory } from "@app/keystore/keystore";
import { getConfig, IS_PACKAGED } from "@app/lib/config/env";
import { TQueueServiceFactory } from "@app/queue";
import { HsmModule } from "@app/services/hsm/hsm-types";
import { TSmtpService } from "@app/services/smtp/smtp-service";

import { globalRateLimiterCfg } from "./config/rateLimiter";
Expand Down
4 changes: 2 additions & 2 deletions backend/src/server/routes/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ import { externalKmsServiceFactory } from "@app/ee/services/external-kms/externa
import { groupDALFactory } from "@app/ee/services/group/group-dal";
import { groupServiceFactory } from "@app/ee/services/group/group-service";
import { userGroupMembershipDALFactory } from "@app/ee/services/group/user-group-membership-dal";
import { hsmServiceFactory } from "@app/ee/services/hsm/hsm-service";
import { HsmModule } from "@app/ee/services/hsm/hsm-types";
import { identityProjectAdditionalPrivilegeDALFactory } from "@app/ee/services/identity-project-additional-privilege/identity-project-additional-privilege-dal";
import { identityProjectAdditionalPrivilegeServiceFactory } from "@app/ee/services/identity-project-additional-privilege/identity-project-additional-privilege-service";
import { identityProjectAdditionalPrivilegeV2ServiceFactory } from "@app/ee/services/identity-project-additional-privilege-v2/identity-project-additional-privilege-v2-service";
Expand Down Expand Up @@ -105,8 +107,6 @@ import { externalMigrationServiceFactory } from "@app/services/external-migratio
import { groupProjectDALFactory } from "@app/services/group-project/group-project-dal";
import { groupProjectMembershipRoleDALFactory } from "@app/services/group-project/group-project-membership-role-dal";
import { groupProjectServiceFactory } from "@app/services/group-project/group-project-service";
import { hsmServiceFactory } from "@app/services/hsm/hsm-service";
import { HsmModule } from "@app/services/hsm/hsm-types";
import { identityDALFactory } from "@app/services/identity/identity-dal";
import { identityMetadataDALFactory } from "@app/services/identity/identity-metadata-dal";
import { identityOrgDALFactory } from "@app/services/identity/identity-org-dal";
Expand Down
4 changes: 2 additions & 2 deletions backend/src/server/routes/v1/admin-router.ts
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ export const registerAdminRouter = async (server: FastifyZodProvider) => {

server.route({
method: "GET",
url: "/root-kms-config",
url: "/encryption-strategies",
config: {
rateLimit: readLimit
},
Expand Down Expand Up @@ -228,7 +228,7 @@ export const registerAdminRouter = async (server: FastifyZodProvider) => {
});

server.route({
method: "POST",
method: "PATCH",
url: "/encryption-strategies",
config: {
rateLimit: writeLimit
Expand Down
2 changes: 1 addition & 1 deletion backend/src/services/kms/kms-service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import {
KmsProviders,
TExternalKmsProviderFns
} from "@app/ee/services/external-kms/providers/model";
import { THsmServiceFactory } from "@app/ee/services/hsm/hsm-service";
import { KeyStorePrefixes, TKeyStoreFactory } from "@app/keystore/keystore";
import { getConfig } from "@app/lib/config/env";
import { randomSecureBytes } from "@app/lib/crypto";
Expand All @@ -19,7 +20,6 @@ import { logger } from "@app/lib/logger";
import { alphaNumericNanoId } from "@app/lib/nanoid";
import { getByteLengthForAlgorithm, KMS_ROOT_CONFIG_UUID } from "@app/services/kms/kms-fns";

import { THsmServiceFactory } from "../hsm/hsm-service";
import { TOrgDALFactory } from "../org/org-dal";
import { TProjectDALFactory } from "../project/project-dal";
import { TInternalKmsDALFactory } from "./internal-kms-dal";
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/hooks/api/admin/mutation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ export const useUpdateServerEncryptionStrategy = () => {
const queryClient = useQueryClient();
return useMutation({
mutationFn: async (strategy: RootKeyEncryptionStrategy) => {
await apiRequest.post("/api/v1/admin/encryption-strategies", { strategy });
await apiRequest.patch("/api/v1/admin/encryption-strategies", { strategy });
},
onSuccess: () => {
queryClient.invalidateQueries(adminQueryKeys.getServerEncryptionStrategies());
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/hooks/api/admin/queries.ts
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ export const useGetServerRootKmsEncryptionDetails = () => {
queryKey: adminQueryKeys.getServerEncryptionStrategies(),
queryFn: async () => {
const { data } = await apiRequest.get<TGetServerRootKmsEncryptionDetails>(
"/api/v1/admin/root-kms-config"
"/api/v1/admin/encryption-strategies"
);

return data;
Expand Down

0 comments on commit f8f7b73

Please sign in to comment.