Adds username support #154
Conversation
|
@divyanshu-rawat Please review. |
| } = req; | ||
| try { | ||
| const userObject: InterfaceUserModel | null = await User.findOne({ email }); | ||
| const userObject: InterfaceUserModel | null = await User.findOne({ $or: [ { email }, { userName } ] }); |
There was a problem hiding this comment.
do you really think we need or operator here, as described in schema username is unique so DB will throw an error if username/ email is not unique? and I think in your case it won't even go to userName, as email will never be null. Let me know your thought on it, or correct me if I am wrong.
There was a problem hiding this comment.
Ok so I have put an or condition for a case like this. Let's assume we already have a user { ashu, [email protected]} . This particular condition would prevent a user { ashu, [email protected]} , {ashuK, [email protected]} and { ashu, [email protected]} from registering. This condition ensures uniqueness of both email and username for a new user. In login controller, this same condition ensures the user can either login with user name or email.
There was a problem hiding this comment.
I just modified the query. I think we need the userObject for socialLoginCheck function.
There was a problem hiding this comment.
Yeah looks good, didn't know about $or operator, though my intitution was defining unique in schema ensures uniqueness of both email and username for a new user.
| } = req; | ||
| try { | ||
| const userObject: InterfaceUserModel | null = await User.findOne({ email }); | ||
| const userObject: InterfaceUserModel | null = await User.findOne({ $or: [ { email }, { userName } ] }); |
There was a problem hiding this comment.
Yeah looks good, didn't know about $or operator, though my intitution was defining unique in schema ensures uniqueness of both email and username for a new user.
Closes #152