Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client username support 🚀 #878

Closed
divyanshu-rawat opened this issue Jun 26, 2020 · 0 comments
Closed

Client username support 🚀 #878

divyanshu-rawat opened this issue Jun 26, 2020 · 0 comments
Labels
enhancement New feature or improvement of existing feature. help wanted Extra attention is needed.

Comments

@divyanshu-rawat
Copy link
Member

Is your feature request related to a problem? Please describe.
We have decided to add username support to Ignitus.
Currently, the ignitus-server has an open PR to add username support to the Ignitus web application.
Here is the PR - Ignitus/Ignitus-rest-api#154

Implementation can be divide into 2 steps:
1 - Add username support to signUp.
2 - Add username support to logIn.

1st one can be achieved by adding an additional Input on signUp page http://www.ignitus.org/signup/student, http://www.ignitus.org/signup/professor.

Here is the file that shares component between signUp & logIn pages https://github.com/Ignitus/Ignitus-client/blob/master/src/ignitus-Shared/ignitus-DesignSystem/ignitus-Templates/ignitus-Authentication/Components/SplittedComponents/FormComponent/index.tsx.

In the IInd one keep in mind you don't need to add any field, we want the user to enter either email or username, something like email/username.
Please go through back end implementation before starting to work on this issue.

Describe the solution you'd like

  • Signup should contain an Input to ask for username during regestration.
  • LogIn should take either the email or username.

Describe alternatives you've considered
N.A

Additional context
Source Code of authentication

Please let me know if you have any Questions regarding this issue we can have a conversation here or on slack. 🚀

@divyanshu-rawat divyanshu-rawat added enhancement New feature or improvement of existing feature. help wanted Extra attention is needed. Internship Issues only for the SWE interns and removed Internship Issues only for the SWE interns labels Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement of existing feature. help wanted Extra attention is needed.
Projects
None yet
Development

No branches or pull requests

1 participant