added frontend support for username #882
Conversation
There was a problem hiding this comment.
UI looks good to me but functionally is still missing @Dishebh, feel free to trace back to the state that <Form /> component is receiving.
There was a problem hiding this comment.
It still doesn't send username to server. To do that,
- return
usernameas well insidesignUpRequest. - Inside
sagas.ts(in same folder), destructusername& pass it along with email, password insidecall. - In
ignitus-Api/index, addusernameas argument & axios post body. [Make sure arguments order of step 2 & 3 are same].
Learn basic redux-saga concepts to get the flow.
|
How should I enable the support for both |
|
@divyanshu-rawat just read how email & password is being sent to server from front-end :) |
|
@divyanshu-rawat there should be a more optimized way of doing it. Please review the changes done now. Thanks |
|
@divyanshu-rawat Are we relying on front end to decide whether it is email or username? |
| logInRequestUsingUsername(userName, password, 'professor'); | ||
| setState(LoginStatePayload); | ||
| } else { | ||
| logInRequestUsingEmail({ email: userName }, password, 'professor'); |
There was a problem hiding this comment.
It will produce error everytime, as logInRequestUsingEmail accept first argument as string.
Fixes #878