Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile Detail View UI #753

Merged
merged 27 commits into from
Apr 18, 2020
Merged
Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
f8cc6d0
Merge branch 'develop' of https://github.com/Meghana-12/Ignitus-clien…
meghanacosmos Apr 8, 2020
6e17eeb
Merge branch 'develop' of https://github.com/Ignitus/Ignitus-client i…
meghanacosmos Apr 8, 2020
87be670
Added Profile View UI
meghanacosmos Apr 8, 2020
c35056d
removed unused import
meghanacosmos Apr 8, 2020
49c57db
Update profileDetailView.tsx
meghanacosmos Apr 8, 2020
d628a49
Update profileDetailView.tsx
meghanacosmos Apr 8, 2020
df9e8bb
Merge branch 'profileUI' of /Users/varanasimeghana/Project/Ignitus-cl…
meghanacosmos Apr 8, 2020
e941fd7
did the changes requseted
meghanacosmos Apr 8, 2020
d783155
Merge branch 'develop' into profileUI
divyanshu-rawat Apr 10, 2020
92b1b67
Merge branch 'develop' into profileUI
divyanshu-rawat Apr 10, 2020
b76d357
push test.
divyanshu-rawat Apr 10, 2020
034ff8e
Reverting changes 🔨
divyanshu-rawat Apr 10, 2020
6c44c3f
added more components
meghanacosmos Apr 17, 2020
07e3398
removed unused imports
meghanacosmos Apr 17, 2020
9c7a911
Update src/ignitus-Profile/ignitus-StudentProfile/Components/profileD…
divyanshu-rawat Apr 18, 2020
26c39bd
Refactoring 🔨
divyanshu-rawat Apr 18, 2020
f1356c8
Merge branch 'develop' into profileUI
divyanshu-rawat Apr 18, 2020
ec11e20
Refactoring 🎯
divyanshu-rawat Apr 18, 2020
1ba1ec1
Refactoring 🎯
divyanshu-rawat Apr 18, 2020
3a86c9b
Refactoring 🔨
divyanshu-rawat Apr 18, 2020
7507212
Contribution section refactoring 🔨
divyanshu-rawat Apr 18, 2020
10ce4e9
Refactoring 🔨
divyanshu-rawat Apr 18, 2020
4396810
Further refactoring & cleanup 🎯
divyanshu-rawat Apr 18, 2020
19875ce
Refactoring 🎯
divyanshu-rawat Apr 18, 2020
6db2dfe
Final cleanup 👋
divyanshu-rawat Apr 18, 2020
703d0f0
Minor Fixes 🎯
divyanshu-rawat Apr 18, 2020
c8b96d5
DeepScan fixes 🔨
divyanshu-rawat Apr 18, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export { default as ProfileDetailView } from './profileDetailView';
Original file line number Diff line number Diff line change
@@ -0,0 +1,193 @@
import React from 'react';
import {StyledHeading2, StyledHeading4, StyledHeading6} from '../../../ignitus-UserInterfaceBook/styles';
import * as P from '../styles';
import {AppIcon} from '../../../ignitus-Shared/types/iconsTypes/iconEnums';
import {
ButtonBottomRight,
RoundedButton,
} from '../../../ignitus-Shared/ignitus-DesignSystem/ignitus-Atoms/buttons';
import {AboutContent} from '../styles';


const ProfileDetailView = () => (
<P.Container1>
meghanacosmos marked this conversation as resolved.
Show resolved Hide resolved
meghanacosmos marked this conversation as resolved.
Show resolved Hide resolved

<P.Container2>
meghanacosmos marked this conversation as resolved.
Show resolved Hide resolved
meghanacosmos marked this conversation as resolved.
Show resolved Hide resolved
<ButtonBottomRight size="large" category="primary" > Edit Profile</ButtonBottomRight>
</P.Container2>
<P.Container3>
meghanacosmos marked this conversation as resolved.
Show resolved Hide resolved
<P.ElementContainer>
meghanacosmos marked this conversation as resolved.
Show resolved Hide resolved
<P.HeadingContainer>
meghanacosmos marked this conversation as resolved.
Show resolved Hide resolved
<P.StyledIcon name={AppIcon.InfoIcon} />
<P.NameContainer>
<StyledHeading2>About</StyledHeading2>
meghanacosmos marked this conversation as resolved.
Show resolved Hide resolved
</P.NameContainer>
</P.HeadingContainer>

<P.ContentContainer>
<AboutContent
meghanacosmos marked this conversation as resolved.
Show resolved Hide resolved
placeholder="Well-versed in over a dozen literary genres and can teach to any range of students. Adept at creating a lesson plan that engages students helping students to see the beauty in literature and encouraging students to read on their own. Specializes in high school and junior college level classes."
rows={3}
/>

</P.ContentContainer>
</P.ElementContainer>

<P.ElementContainer>
meghanacosmos marked this conversation as resolved.
Show resolved Hide resolved
<P.HeadingContainer>
meghanacosmos marked this conversation as resolved.
Show resolved Hide resolved
<P.StyledIcon name={AppIcon.GraduationCapIcon} />
<P.NameContainer>
<StyledHeading2>Education</StyledHeading2>
</P.NameContainer>
</P.HeadingContainer>

<P.ContentContainer>
<StyledHeading6>
<P.Education1
meghanacosmos marked this conversation as resolved.
Show resolved Hide resolved
meghanacosmos marked this conversation as resolved.
Show resolved Hide resolved
placeholder="Graham Junior College"
type="text"
/>
</StyledHeading6>

<StyledHeading4>
<P.Education2
meghanacosmos marked this conversation as resolved.
Show resolved Hide resolved
meghanacosmos marked this conversation as resolved.
Show resolved Hide resolved
placeholder="New Parkland,CA"
type="text"
/>
</StyledHeading4>

<StyledHeading4>
<P.Education3
meghanacosmos marked this conversation as resolved.
Show resolved Hide resolved
meghanacosmos marked this conversation as resolved.
Show resolved Hide resolved
placeholder=" 2015 – 2019 "
type="text"
/>
</StyledHeading4>

</P.ContentContainer>

</P.ElementContainer>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</P.ElementContainer>
</P. ResearchSection >


<P.ElementContainer>
divyanshu-rawat marked this conversation as resolved.
Show resolved Hide resolved
<P.HeadingContainer>
meghanacosmos marked this conversation as resolved.
Show resolved Hide resolved
<P.StyledIcon name={AppIcon.LocalLibraryIcon} />
<P.NameContainer>
<StyledHeading2>Research Fields </StyledHeading2>
</P.NameContainer>
</P.HeadingContainer>

<P.ContentContainer>
<RoundedButton size="medium" category="grey">Psycholinguistics </RoundedButton>
<RoundedButton size="medium" category="grey">Modernist Literature </RoundedButton>
</P.ContentContainer>

</P.ElementContainer>

<P.ElementContainer>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<P.ElementContainer>
<P.PublicationSection>

<P.HeadingContainer>
meghanacosmos marked this conversation as resolved.
Show resolved Hide resolved
<P.StyledIcon name={AppIcon.LibraryBooksIcon} />
<P.NameContainer>
<StyledHeading2> Publications </StyledHeading2>
meghanacosmos marked this conversation as resolved.
Show resolved Hide resolved
</P.NameContainer>
</P.HeadingContainer>

<P.ContentContainer>
<P.Publications>
meghanacosmos marked this conversation as resolved.
Show resolved Hide resolved
<P.PublicationsStyledIcon name={AppIcon.PdfIcon} />
<P.PublicationsInput
placeholder="Shakespeare and Elizabethan Poetry: A Study of His Earlier Work in Relation to the Poetry of the Time"
/>
</P.Publications>
<P.Publications>
<P.PublicationsStyledIcon name={AppIcon.PdfIcon} />
<P.PublicationsInput
meghanacosmos marked this conversation as resolved.
Show resolved Hide resolved
placeholder="Practice in a second language: Perspectives from applied linguistics and cognitive psychology"
/>
</P.Publications>
</P.ContentContainer>

</P.ElementContainer>

<P.ElementContainer>
meghanacosmos marked this conversation as resolved.
Show resolved Hide resolved
<P.HeadingContainer>
<P.StyledIcon name={AppIcon.ContributionIcon} />
<P.NameContainer>
<StyledHeading2>Contributions </StyledHeading2>
</P.NameContainer>
</P.HeadingContainer>

<P.ContentContainer>
<P.ContributionsContent>

<P.ContributionsElement>
<P.ContributionsStyledIcon name={AppIcon.LibraryBooksIcon} />
<P.ContributionsInput
meghanacosmos marked this conversation as resolved.
Show resolved Hide resolved
placeholder=" 5"
type="number"
/>
Articles
</P.ContributionsElement>

<P.ContributionsElement>
<P.ContributionsStyledIcon name={AppIcon.PollIcon} />
<P.ContributionsInput
meghanacosmos marked this conversation as resolved.
Show resolved Hide resolved
placeholder=" 5"
type="number"
/>
Polls
</P.ContributionsElement>
<P.ContributionsElement>
<P.ContributionsStyledIcon name={AppIcon.PdfIcon} />
<P.ContributionsInput
placeholder=" 5"
meghanacosmos marked this conversation as resolved.
Show resolved Hide resolved
type="number"
/>
Publications
</P.ContributionsElement>
<P.ContributionsElement>
<P.ContributionsStyledIcon name={AppIcon.VideoLibIcon} />
<P.ContributionsInput
placeholder=" 5"
meghanacosmos marked this conversation as resolved.
Show resolved Hide resolved
type="number"
/>
Videos
</P.ContributionsElement>
</P.ContributionsContent>
</P.ContentContainer>

</P.ElementContainer>

<P.ElementContainer>
<P.HeadingContainer>
<P.StyledIcon name={AppIcon.StarCircleIcon} />
<P.NameContainer>
<StyledHeading2>Recommendations</StyledHeading2>
</P.NameContainer>
</P.HeadingContainer>

<P.ContentContainer>
meghanacosmos marked this conversation as resolved.
Show resolved Hide resolved
<P.RecommendationsContent1>
<P.RecommendationsAvatar
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<P.RecommendationsAvatar
<P.Avatar

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it is already inside recommendation it simply signifies it is an avatar that belongs to someone who has given recommendation so naming it like Avatar should be fine.

src="../../../ignitus-Shared/ignitus-DesignSystem/ignitus-Assets/ignitus-Images/img-Png/StudentProfileView.png"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image doesn't seem to work, instead use an avatar like 'https://storage.googleapis.com/ignitus_assets/ig-avatars/eugene.png'

alt="Avatar"
/>
<P.RecommendationsContent2>
meghanacosmos marked this conversation as resolved.
Show resolved Hide resolved
<P.RecommendationsInput1 placeholder="Nicholas Young" type="text" />
<P.RecommendationsInput2 placeholder="Professor" type="text"/>
meghanacosmos marked this conversation as resolved.
Show resolved Hide resolved
<P.RecommendationsInput3 placeholder="December 19, 2018" type="text"/>
meghanacosmos marked this conversation as resolved.
Show resolved Hide resolved
</P.RecommendationsContent2>
<P.RecommendationsMainInput
meghanacosmos marked this conversation as resolved.
Show resolved Hide resolved
placeholder="I worked with Sophia in a research paper, for 2 years. She has the ability to understand toughest things effortlessly that skill often takes time to develop, but it seemed to come perfectly naturally to her. It\'s my privilege to Recommendations her even I found myself lucky that I got a chance to be in touch with Sophia."
meghanacosmos marked this conversation as resolved.
Show resolved Hide resolved
rows={5}
/>
</P.RecommendationsContent1>
</P.ContentContainer>
</P.ElementContainer>
</P.Container3>
<P.ButtonDiv>
<RoundedButton size="small" category="grey" >Download as PDF</RoundedButton>
</P.ButtonDiv>
</P.Container1>
);


export default ProfileDetailView;
Loading