Profile Detail View UI #753

meghanacosmos · 2020-04-08T11:51:45Z

Added the UI of Profile detail view, issue: #743.

…into profileUI

…nto profileUI

hound · 2020-04-08T11:51:52Z

...s-Shared/ignitus-DesignSystem/ignitus-Assets/ignitus-Icons/starCircleIcon/starCircleIcon.tsx

@@ -0,0 +1,22 @@
+import React from 'react';
+import {HTMLAttributes} from 'react';
+type Props = HTMLAttributes<SVGElement>;


Parsing error: Unexpected token Props

hound · 2020-04-08T11:51:53Z

...hared/ignitus-DesignSystem/ignitus-Assets/ignitus-Icons/conributionIcon/contributionIcon.tsx

@@ -0,0 +1,22 @@
+import React from 'react';
+import {HTMLAttributes} from 'react';
+type Props = HTMLAttributes<SVGElement>;


Parsing error: Unexpected token Props

Paarmita

@meghana-12 Can you please add a screenshot of your UI in the PR description.

Paarmita · 2020-04-08T12:40:27Z

src/ignitus-Profile/ignitus-StudentProfile/Components/profileDetailView.tsx

@@ -0,0 +1,195 @@
+import React from 'react';
+import { StyledHeading2, StyledHeading4, StyledHeading6 } from '../../../ignitus-UserInterfaceBook/styles';
+import * as C from '../styles';


We use C generally for importing colors, can you please user P for Profile

Paarmita · 2020-04-08T12:42:46Z

src/ignitus-Profile/ignitus-StudentProfile/styles.ts

+`;
+
+export const Container2 = styled.div`
+  margin-right: -0.3rem;


Don't use margin in negative.

Paarmita · 2020-04-08T12:43:05Z

src/ignitus-Profile/ignitus-StudentProfile/styles.ts

+`;
+
+export const HeadingContainer = styled(flexibleRowDiv)`
+  // padding-top: 3rem;


Remove comments

Paarmita · 2020-04-08T12:44:39Z

src/ignitus-Profile/ignitus-StudentProfile/styles.ts

+  flex-wrap: wrap;
+`;
+
+export const ContriElement = styled(flexibleRowDiv)`


Please try to use understandable convention names instead of Contri

sure, I'll edit that

…ient with conflicts.

src/ignitus-Profile/ignitus-StudentProfile/Components/profileDetailView.tsx

divyanshu-rawat

A visual representation of flex layout for recommendation section, layout is not that clean but will give you hints how you should use flex.

One tutorial that will certainly help you to better use flex is https://flexboxfroggy.com/

src/ignitus-Profile/ignitus-StudentProfile/Components/profileDetailView.tsx

src/ignitus-Profile/ignitus-StudentProfile/styles.ts

divyanshu-rawat · 2020-04-10T19:12:55Z

@meghana-12 please remove the .png image added as well, and use the avatar I suggested., please delete the Image.

codecov · 2020-04-10T20:11:01Z

Codecov Report

Merging #753 into develop will decrease coverage by 0.00952%.
The diff coverage is n/a.

@@                Coverage Diff                @@
##            develop       #753         +/-   ##
=================================================
- Coverage   0.56818%   0.55866%   -0.00951%     
=================================================
  Files             5          6          +1     
  Lines           176        179          +3     
  Branches         48         48                 
=================================================
  Hits              1          1                 
- Misses          175        178          +3

Impacted Files	Coverage Δ
...c/ignitus-Routes/ignitus-DashboardRoutes/index.jsx	`0.00000% <0.00000%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0d2f05...c8b96d5. Read the comment docs.

hound · 2020-04-17T17:07:36Z

src/ignitus-Profile/ignitus-StudentProfile/types.ts

@@ -0,0 +1,33 @@
+import {AppIcon} from '../../ignitus-Shared/types/iconsTypes/iconEnums';
+
+export type HeadingProps = {


Parsing error: Unexpected token type

…etailView.tsx

divyanshu-rawat · 2020-04-18T08:52:22Z

src/ignitus-Profile/ignitus-StudentProfile/Components/profileDetailView.tsx

+          <RoundedButton size="medium" category="grey">Psycholinguistics </RoundedButton>
+          <RoundedButton size="medium" category="grey">Modernist Literature  </RoundedButton>
+        </P.ContentContainer>
+      </P.ElementContainer>


Suggested change

</P.ElementContainer>

</P. ResearchSection >

hound · 2020-04-18T11:24:05Z

src/ignitus-AboutPage/ignitus-Team/Styles/index.ts

 import {Paragraph} from '../../../ignitus-Shared/ignitus-DesignSystem/ignitus-Atoms/typography';
 import {Loading} from '../../../ignitus-Shared/ignitus-Utilities/Components/loader';
+import {Normal} from '../../../ignitus-Shared/ignitus-DesignSystem/ignitus-Atoms/fonts';
+import {default as I} from '../../../ignitus-Shared/ignitus-Utilities/Components/icon';


A space is required after '{' object-curly-spacing
A space is required before '}' object-curly-spacing
Use default import syntax to import 'I' import/no-named-default

hound · 2020-04-18T11:24:05Z

src/ignitus-AboutPage/ignitus-Team/Styles/index.ts

 import {Paragraph} from '../../../ignitus-Shared/ignitus-DesignSystem/ignitus-Atoms/typography';
 import {Loading} from '../../../ignitus-Shared/ignitus-Utilities/Components/loader';
+import {Normal} from '../../../ignitus-Shared/ignitus-DesignSystem/ignitus-Atoms/fonts';


A space is required after '{' object-curly-spacing
A space is required before '}' object-curly-spacing

hound · 2020-04-18T11:24:05Z

src/ignitus-Profile/ignitus-StudentProfile/styles.ts

+  font-weight: ${props =>
+    props.fontStyle === 'paragraph' ? F.Medium : F.Bold};
+  font-size: ${props => (props.fontStyle === 'paragraph' ? F.SM : F.MD)};
+  color: ${props =>


Arrow function used ambiguously with a conditional expression no-confusing-arrow

hound · 2020-04-18T11:24:05Z

src/ignitus-Profile/ignitus-StudentProfile/styles.ts

+
+export const Title = styled(Heading5)<TitleProps>`
+  padding: 0.5rem 2rem;
+  font-weight: ${props =>


Arrow function used ambiguously with a conditional expression no-confusing-arrow

hound · 2020-04-18T11:24:06Z

src/ignitus-Profile/ignitus-StudentProfile/styles.ts

+  margin: 1.5rem 0;
+`;
+
+export const Title = styled(Heading5)<TitleProps>`


Infix operators must be spaced space-infix-ops
Unexpected mix of '<' and '>' no-mixed-operators

hound · 2020-04-18T11:24:06Z

src/ignitus-Profile/ignitus-StudentProfile/styles.ts

+  Heading6,
+} from '../../ignitus-Shared/ignitus-DesignSystem/ignitus-Atoms/typography';
+import {TitleProps} from './types';
+import {default as I} from '../../ignitus-Shared/ignitus-Utilities/Components/icon';


A space is required after '{' object-curly-spacing
A space is required before '}' object-curly-spacing
Use default import syntax to import 'I' import/no-named-default

hound · 2020-04-18T11:24:06Z

src/ignitus-Profile/ignitus-StudentProfile/styles.ts

+  Paragraph,
+  Heading6,
+} from '../../ignitus-Shared/ignitus-DesignSystem/ignitus-Atoms/typography';
+import {TitleProps} from './types';


A space is required after '{' object-curly-spacing
A space is required before '}' object-curly-spacing

hound · 2020-04-18T11:24:06Z

src/ignitus-Profile/ignitus-StudentProfile/Components/index.tsx

+  </P.ParentContainer>
+);
+
+const Heading = ({title, icon, fontStyle}: HeadingProps) => (


Parsing error: Unexpected token :

hound · 2020-04-18T11:24:06Z

src/ignitus-Shared/ignitus-DesignSystem/ignitus-Assets/ignitus-Icons/starCircleIcon/index.ts

@@ -0,0 +1 @@
+export {default} from './starCircleIcon';


A space is required after '{' object-curly-spacing
A space is required before '}' object-curly-spacing
Do not alias default as default. Just export default itself instead import/no-default-export

hound · 2020-04-18T11:24:07Z

src/ignitus-Shared/ignitus-DesignSystem/ignitus-Assets/ignitus-Icons/conributionIcon/index.ts

@@ -0,0 +1 @@
+export {default} from './contributionIcon';


A space is required after '{' object-curly-spacing
A space is required before '}' object-curly-spacing
Do not alias default as default. Just export default itself instead import/no-default-export

divyanshu-rawat

LGTM :)

meghanacosmos added 3 commits April 8, 2020 11:47

Merge branch 'develop' of https://github.com/Meghana-12/Ignitus-client …

f8cc6d0

…into profileUI

Merge branch 'develop' of https://github.com/Ignitus/Ignitus-client i…

6e17eeb

…nto profileUI

Added Profile View UI

87be670

pr-triage bot added the PR: unreviewed label Apr 8, 2020

hound bot reviewed Apr 8, 2020

View reviewed changes

auto-assign bot requested review from divyanshu-rawat, gittysachin, Marvin9 and Paarmita April 8, 2020 11:53

meghanacosmos and others added 3 commits April 8, 2020 17:24

removed unused import

c35056d

Update profileDetailView.tsx

49c57db

Update profileDetailView.tsx

d628a49

Paarmita requested changes Apr 8, 2020

View reviewed changes

pr-triage bot added PR: reviewed-changes-requested and removed PR: unreviewed labels Apr 8, 2020

meghanacosmos added 2 commits April 8, 2020 18:54

Merge branch 'profileUI' of /Users/varanasimeghana/Project/Ignitus-cl…

df9e8bb

…ient with conflicts.

did the changes requseted

e941fd7

pr-triage bot added PR: unreviewed and removed PR: reviewed-changes-requested labels Apr 8, 2020

meghanacosmos requested a review from Paarmita April 8, 2020 13:51

Paarmita linked an issue Apr 10, 2020 that may be closed by this pull request

Dashboard: Profile detail view #743

Closed

divyanshu-rawat reviewed Apr 10, 2020

View reviewed changes

src/ignitus-Profile/ignitus-StudentProfile/Components/profileDetailView.tsx Outdated Show resolved Hide resolved

divyanshu-rawat requested changes Apr 10, 2020

View reviewed changes

pr-triage bot added PR: reviewed-changes-requested and removed PR: unreviewed labels Apr 10, 2020

divyanshu-rawat added 3 commits April 10, 2020 21:56

Merge branch 'develop' into profileUI

d783155

Merge branch 'develop' into profileUI

92b1b67

push test.

b76d357

pr-triage bot removed the PR: reviewed-changes-requested label Apr 10, 2020

divyanshu-rawat mentioned this pull request Apr 10, 2020

Pushing to PR fails. #771

Closed

divyanshu-rawat and others added 2 commits April 10, 2020 22:19

Reverting changes 🔨

034ff8e

added more components

6c44c3f

hound bot reviewed Apr 17, 2020

View reviewed changes

removed unused imports

07e3398

meghanacosmos requested a review from divyanshu-rawat April 17, 2020 17:17

Update src/ignitus-Profile/ignitus-StudentProfile/Components/profileD…

9c7a911

…etailView.tsx

divyanshu-rawat reviewed Apr 18, 2020

View reviewed changes

divyanshu-rawat added 10 commits April 18, 2020 11:09

Refactoring 🔨

26c39bd

Merge branch 'develop' into profileUI

f1356c8

Refactoring 🎯

ec11e20

Refactoring 🎯

1ba1ec1

Refactoring 🔨

3a86c9b

Contribution section refactoring 🔨

7507212

Refactoring 🔨

10ce4e9

Further refactoring & cleanup 🎯

4396810

Refactoring 🎯

19875ce

Final cleanup 👋

6db2dfe

hound bot reviewed Apr 18, 2020

View reviewed changes

divyanshu-rawat added 2 commits April 18, 2020 13:30

Minor Fixes 🎯

703d0f0

DeepScan fixes 🔨

c8b96d5

divyanshu-rawat approved these changes Apr 18, 2020

View reviewed changes

pr-triage bot added PR: partially-approved and removed PR: unreviewed labels Apr 18, 2020

divyanshu-rawat merged commit 14efd4d into Ignitus:develop Apr 18, 2020

pr-triage bot added PR: merged and removed PR: partially-approved labels Apr 18, 2020

divyanshu-rawat mentioned this pull request Apr 18, 2020

Master > Develop #793

Merged

meghanacosmos deleted the profileUI branch April 30, 2020 19:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Profile Detail View UI #753

Profile Detail View UI #753

meghanacosmos commented Apr 8, 2020 •

edited

Loading

hound bot Apr 8, 2020

hound bot Apr 8, 2020

Paarmita left a comment

Paarmita Apr 8, 2020

meghanacosmos Apr 8, 2020

Paarmita Apr 8, 2020

meghanacosmos Apr 8, 2020

Paarmita Apr 8, 2020

meghanacosmos Apr 8, 2020

Paarmita Apr 8, 2020

meghanacosmos Apr 8, 2020

divyanshu-rawat left a comment

divyanshu-rawat commented Apr 10, 2020

codecov bot commented Apr 10, 2020 •

edited

Loading

hound bot Apr 17, 2020

divyanshu-rawat Apr 18, 2020

hound bot Apr 18, 2020

hound bot Apr 18, 2020

hound bot Apr 18, 2020

hound bot Apr 18, 2020

hound bot Apr 18, 2020

hound bot Apr 18, 2020

hound bot Apr 18, 2020

hound bot Apr 18, 2020

hound bot Apr 18, 2020

hound bot Apr 18, 2020

divyanshu-rawat left a comment

		@@ -0,0 +1,33 @@
		import {AppIcon} from '../../ignitus-Shared/types/iconsTypes/iconEnums';

		export type HeadingProps = {

Profile Detail View UI #753

Profile Detail View UI #753

Conversation

meghanacosmos commented Apr 8, 2020 • edited Loading

hound bot Apr 8, 2020

Choose a reason for hiding this comment

hound bot Apr 8, 2020

Choose a reason for hiding this comment

Paarmita left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

divyanshu-rawat left a comment

Choose a reason for hiding this comment

divyanshu-rawat commented Apr 10, 2020

codecov bot commented Apr 10, 2020 • edited Loading

Codecov Report

hound bot Apr 17, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hound bot Apr 18, 2020

Choose a reason for hiding this comment

hound bot Apr 18, 2020

Choose a reason for hiding this comment

hound bot Apr 18, 2020

Choose a reason for hiding this comment

hound bot Apr 18, 2020

Choose a reason for hiding this comment

hound bot Apr 18, 2020

Choose a reason for hiding this comment

hound bot Apr 18, 2020

Choose a reason for hiding this comment

hound bot Apr 18, 2020

Choose a reason for hiding this comment

hound bot Apr 18, 2020

Choose a reason for hiding this comment

hound bot Apr 18, 2020

Choose a reason for hiding this comment

hound bot Apr 18, 2020

Choose a reason for hiding this comment

divyanshu-rawat left a comment

Choose a reason for hiding this comment

meghanacosmos commented Apr 8, 2020 •

edited

Loading

codecov bot commented Apr 10, 2020 •

edited

Loading