test: replace realistic location coordinates

[IceCodeNew]

Follow-up to #75.

Addresses the test-data privacy/compliance finding in:

• feat: add Japan JMA forecast capability #75 (comment)

Replaces Tokyo/Osaka latitude and longitude literals used only as test placeholders with clearly dummy 1.0, 1.0 coordinates. Tests continue to express regional behavior through explicit country codes, timezones, and JMA office codes, so production behavior and test intent are unchanged.

Verification:

• 785 tests passed with branch coverage
• line coverage 99.85% (increased from 99.78%)
• repository tests contain none of the reviewed coordinate literals
• prek run --all-files

[coderabbitai]

Warning

Review limit reached

@IceCodeNew, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 51 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: da7d356c-55f9-4bb0-bb94-5b10adfc2ac6

📥 Commits

Reviewing files that changed from the base of the PR and between baf5ca8 and 1690d05.

📒 Files selected for processing (5)

• tests/test_cli.py
• tests/test_config.py
• tests/test_geocoding.py
• tests/test_languages.py
• tests/test_regional_weather.py

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/sanitize-test-coordinates

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[IceCodeNew]

/agentic_review

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.78%. Comparing base (baf5ca8) to head (1690d05).
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##           master      #80   +/-   ##
=======================================
  Coverage   99.78%   99.78%           
=======================================
  Files          45       45           
  Lines        8394     8394           
  Branches      488      488           
=======================================
  Hits         8376     8376           
  Misses         13       13           
  Partials        5        5           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

[qodo-code-review]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Previous review results

Review updated until commit 1690d05 ⚖️ Balanced

Results up to commit 1690d05 ⚖️ Balanced

No changes from previous review

[qodo-code-review]

PR Summary by Qodo

Sanitize test coordinates by replacing Tokyo/Osaka lat/long literals

🧪 Tests 🕐 10-20 Minutes

AI Description

• Replace realistic JP coordinate literals in tests with dummy 1.0, 1.0 placeholders
• Preserve regional intent via country codes, timezones, and JMA office codes
• Update provider calls to use the same sanitized coordinates for consistency

Diagram

graph TD
  cli["tests/test_cli.py"] --> dummy(("Dummy coords 1.0,1.0")) --> jma["JMAJapanForecastProvider"]
  regional["tests/test_regional_weather.py"] --> dummy --> jma
  config["tests/test_config.py"] --> dummy --> resolved["ResolvedLocation"]
  langs["tests/test_languages.py"] --> dummy --> resolved
  geo["tests/test_geocoding.py"] --> dummy --> spec["LocationSpec"]

Loading

High-Level Assessment

The following are alternative approaches to this PR:

1. Introduce shared test constants/fixtures for dummy coordinates

• ➕ Avoids repeating 1.0, 1.0 across multiple test modules
• ➕ Makes future compliance-driven substitutions one-line changes
• ➕ Improves readability by naming intent (e.g., DUMMY_LAT/DUMMY_LON)
• ➖ Slight indirection for very simple literals
• ➖ Requires touching additional test plumbing (conftest/fixtures)

2. Use a clearly invalid sentinel (e.g., NaN) and assert it is never used for geospatial logic

• ➕ Guarantees tests cannot accidentally depend on numeric coordinate behavior
• ➕ Forces explicit separation of coordinate-independent region logic
• ➖ May break code paths that validate numeric ranges/types
• ➖ Higher refactor cost and risk than the current safe literal swap

Recommendation: The current literal swap to 1.0, 1.0 is the best immediate fix: it addresses privacy/compliance with minimal risk and preserves the test intent via explicit metadata (country/timezone/JMA office codes). Consider a small follow-up to centralize dummy coordinates in a shared constant/fixture to reduce duplication.

Files changed (5) +22 / -22

Tests (5) +22 / -22

test_cli.pyReplace Tokyo coordinate literals in CLI/provider-context tests +6/-6

Replace Tokyo coordinate literals in CLI/provider-context tests

• Swaps hardcoded Tokyo latitude/longitude values for dummy '1.0, 1.0' when constructing 'ResolvedLocation'. Updates the JMA provider 'fetch_for_date' call to use the same sanitized coordinates.

tests/test_cli.py

test_config.pySanitize Osaka/Tokyo coordinates in config default and invariant tests +6/-6

Sanitize Osaka/Tokyo coordinates in config default and invariant tests

• Replaces Osaka/Tokyo coordinate literals with '1.0, 1.0' for 'ResolvedLocation' instances used in provider-default selection tests. Keeps JMA office code invariant coverage unchanged while removing realistic coordinates.

tests/test_config.py

test_geocoding.pyUse dummy coordinates for out-of-bounds resolver case +1/-1

Use dummy coordinates for out-of-bounds resolver case

• Replaces Tokyo coordinate literals with '1.0, 1.0' in a 'LocationSpec' used to exercise resolver behavior while a geocoder fails. The behavioral intent (outside service bounds) remains expressed via test logic, not the exact coordinates.

tests/test_geocoding.py

test_languages.pyReplace Tokyo coordinates in language normalization/validation tests +4/-4

Replace Tokyo coordinates in language normalization/validation tests

• Uses dummy '1.0, 1.0' coordinates for 'ResolvedLocation' instances in language field normalization and invalid-language rejection tests. Ensures tests focus on language semantics, not realistic location values.

tests/test_languages.py

test_regional_weather.pySanitize coordinates passed into JMA provider tests +5/-5

Sanitize coordinates passed into JMA provider tests

• Replaces Tokyo latitude/longitude literals with '1.0, 1.0' in JMA provider 'fetch' and 'fetch_for_date' calls. Maintains error-handling and parsing coverage while removing realistic coordinates from test payload scenarios.

tests/test_regional_weather.py

[qodo-code-review]

Code review by qodo was updated up to the latest commit 1690d05