Skip to content

Conversation

@rerpha
Copy link
Contributor

@rerpha rerpha commented Feb 27, 2025

Description of work

Closes #416

This PR:

  • removes jenkins job that runs inst_servers tests on PRs and periodically and replaces both with github actions
  • adds a badge for the periodic runs so we see them regularly
  • adds a requirements.txt for the above so that github actions can run the tests with a clean install
  • uses pytest to collect tests rather than having lots of run_tests.py files which has caused issues with tests not being run in the past

next steps to do after this:

To test

see CI result.

Acceptance criteria

Jenkins is not used

After this is merged, please remove the jenkins job from the branch protection ruleset.


Code Review

  • Is the code of an acceptable quality?
  • Has the author taken into account the multi-threaded nature of the code?
  • Have the changes been recorded appropriately in a PR for release notes?
  • Has the manual system tests spreadsheet been updated?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed.

Final steps

  • Reviewer has updated the submodule in the main EPICS repo? See Reviewing work for the subModules of EPICS in the Git workflow page for details.
  • Reviewer has merged the associated PR for the release notes

@rerpha
Copy link
Contributor Author

rerpha commented Feb 27, 2025

needs ISISComputingGroup/reusable-workflows#15 to run pyright on windows for epicscorelibs...

@rerpha
Copy link
Contributor Author

rerpha commented Feb 27, 2025

I cannot for the life of me figure out why pyright is whinging about not being able to find genie-python - it seems to use the same mechanism as the tests...

@rerpha rerpha moved this to Review in PI_2025_02 Feb 27, 2025
@rerpha rerpha mentioned this pull request Feb 28, 2025
7 tasks
@rerpha rerpha self-assigned this Feb 28, 2025
@rerpha
Copy link
Contributor Author

rerpha commented Mar 10, 2025

think CI is broken because of pypa/distutils#336

@rerpha rerpha requested a review from Tom-Willemsen March 11, 2025 10:13
@rerpha rerpha merged commit 9385fbd into master Mar 11, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from Review to Done in PI_2025_02 Mar 11, 2025
@rerpha rerpha deleted the github_actions_run_pr_tests branch March 11, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

use github actions to run tests against PRs and periodically

3 participants