-
Notifications
You must be signed in to change notification settings - Fork 3
GitHub actions run pr tests #414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ComputingGroup/EPICS-inst_servers into github_actions_run_pr_tests
Contributor
Author
|
needs ISISComputingGroup/reusable-workflows#15 to run pyright on windows for epicscorelibs... |
Contributor
Author
|
I cannot for the life of me figure out why pyright is whinging about not being able to find genie-python - it seems to use the same mechanism as the tests... |
Contributor
Author
|
think CI is broken because of pypa/distutils#336 |
Tom-Willemsen
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Closes #416
This PR:
next steps to do after this:
create_virtual_env.bat)create_virtual_env.batas a step in the upgrade scriptsTo test
see CI result.
Acceptance criteria
Jenkins is not used
After this is merged, please remove the jenkins job from the branch protection ruleset.
Code Review
Functional Tests
Final steps