Merge pull request #414 from ISISComputingGroup/github_actions_run_pr_tests

GitHub actions run pr tests

Author: rerpha

.github/workflows/lint-and-test-nightly.yml

@@ -0,0 +1,8 @@
+name: lint-and-test-nightly
+on:
+  schedule:
+    - cron: "0 0 * * *"
+
+jobs:
+  lint-and-test-nightly:
+   uses: ./.github/workflows/lint-and-test.yml

.github/workflows/lint-and-test.yml

@@ -0,0 +1,24 @@
+name: Lint-and-test
+on: [pull_request]
+jobs:
+  call-workflow:
+    uses: ISISComputingGroup/reusable-workflows/.github/workflows/linters.yml@main
+    with:
+      compare-branch: origin/master
+      runs-on: windows-latest
+      python-ver: '3.11'
+      requirements-path: requirements-dev.txt
+  tests:
+    runs-on: "windows-latest"
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-python@v5
+        with:
+          python-version: '3.11'
+      - name: install requirements
+        run: pip install -r requirements-dev.txt
+        env:
+          PIP_CONSTRAINT: "constraints.txt"
+      - name: run tests (windows)
+        run: python -m pytest --cov
+ 

.github/workflows/linter.yml

@@ -21,33 +21,35 @@
 from BlockServerToKafka.block_server_monitor import BlockServerMonitor
 
 
-@patch("CaChannel.CaChannel")
 class TestBlockServerMonitor(unittest.TestCase):
     test_address = "TEST_ADDRESS"
     test_prefix = "TEST_PREFIX"
 
-    def setUp(self):
+    @patch("CaChannel.CaChannel")
+    @patch("CaChannel.CaChannel.searchw")
+    @patch("CaChannel.CaChannel.add_masked_array_event")
+    @patch("CaChannel.CaChannel.field_type")
+    @patch("CaChannel.CaChannel.pend_event")
+    def setUp(self, *args, **kwargs):
         self.mock_producer = MagicMock()
         self.bs_monitor = BlockServerMonitor(
             self.test_address, self.test_prefix, self.mock_producer
         )
 
     def test_WHEN_convert_one_char_to_string_THEN_returns_character(
         self,
-        mock_ca_channel,
     ):
         c = "a"
         arr = [ord(c)]
         self.assertEqual(c, self.bs_monitor.convert_to_string(bytearray(arr)))
 
-    def test_WHEN_convert_many_chars_to_string_THEN_returns_characters(self, mock_ca_channel):
+    def test_WHEN_convert_many_chars_to_string_THEN_returns_characters(self):
         chars = "hello world"
         arr = [ord(c) for c in chars]
         self.assertEqual(chars, self.bs_monitor.convert_to_string(bytearray(arr)))
 
     def test_WHEN_convert_chars_with_null_at_end_THEN_nulls_removed(
         self,
-        mock_ca_channel,
     ):
         chars = "hello world"
         arr = [ord(c) for c in chars]
@@ -57,35 +59,31 @@ def test_WHEN_convert_chars_with_null_at_end_THEN_nulls_removed(
 
     def test_WHEN_convert_chars_with_null_at_start_THEN_nulls_removed(
         self,
-        mock_ca_channel,
     ):
         chars = "hello world"
         arr = [ord(c) for c in chars]
         for i in range(3):
             arr.insert(0, 0)
         self.assertEqual(chars, self.bs_monitor.convert_to_string(bytearray(arr)))
 
-    def test_WHEN_convert_chars_with_nulls_in_centre_THEN_nulls_removed(self, mock_ca_channel):
+    def test_WHEN_convert_chars_with_nulls_in_centre_THEN_nulls_removed(self):
         chars = "hello world"
         arr = [ord(c) for c in chars]
         arr.insert(4, 0)
         self.assertEqual(chars, self.bs_monitor.convert_to_string(bytearray(arr)))
 
     def test_WHEN_convert_nulls_THEN_empty_string_returned(
         self,
-        mock_ca_channel,
     ):
         arr = [0] * 10
         self.assertEqual("", self.bs_monitor.convert_to_string(bytearray(arr)))
 
-    def test_GIVEN_no_previous_pvs_WHEN_update_config_called_THEN_producer_is_called(
-        self, mock_ca_channel
-    ):
+    def test_GIVEN_no_previous_pvs_WHEN_update_config_called_THEN_producer_is_called(self):
         self.bs_monitor.update_config(["BLOCK"])
         self.mock_producer.add_config.assert_called_once()
 
     def test_GIVEN_no_previous_pvs_WHEN_update_config_called_THEN_producer_is_called_containing_block_name(
-        self, mock_ca_channel
+        self,
     ):
         block = "BLOCK"
         self.bs_monitor.update_config([block])
@@ -94,15 +92,15 @@ def test_GIVEN_no_previous_pvs_WHEN_update_config_called_THEN_producer_is_called
         )
 
     def test_GIVEN_previous_pvs_WHEN_update_config_called_with_same_pvs_THEN_producer_is_not_called(
-        self, mock_ca_channel
+        self,
     ):
         block = "BLOCK"
         self.bs_monitor.update_config([block])
         self.bs_monitor.update_config([block])
         self.mock_producer.add_config.assert_called_once()
 
     def test_GIVEN_previous_pvs_WHEN_update_config_called_with_different_pvs_THEN_producer_is_called(
-        self, mock_ca_channel
+        self,
     ):
         self.bs_monitor.update_config(["OLD_BLOCK"])
         self.mock_producer.reset_mock()