-
-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CtUnresolvedImport): keep all imports in noClassPath mode #2936
Conversation
Ready for reviews! |
src/test/java/spoon/test/jdtimportbuilder/ImportBuilderTest.java
Outdated
Show resolved
Hide resolved
cool stuff, thanks! see my comments. |
Ok Actually I need to add a prettyprinter test. Back to WiP (The test is easy to write but it fails...) |
Related to #2933 |
The current implementation should work BUT it might lead to overlapping import when pretty-printing.
are added (as these types are indeed used) but the import overlap with the pre existing CtUnresolvedImport Edit: This is now solved. |
OK, so now (with this PR), in noClassPath mode:
This mean, that if an |
Equals is not tested https://coveralls.io/builds/23377168/source?filename=src%2Fmain%2Fjava%2Fspoon%2Fexperimental%2FCtUnresolvedImport.java#L73 This is dangerous, could you add one assertTrue and one assertFalse? |
Great feature for the noClasspath mode. Thanks! |
Related to #2927 .