Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CtImportKind.Unresolved #2933

Closed
nharrand opened this issue Apr 5, 2019 · 2 comments
Closed

feat: CtImportKind.Unresolved #2933

nharrand opened this issue Apr 5, 2019 · 2 comments

Comments

@nharrand
Copy link
Collaborator

nharrand commented Apr 5, 2019

I feel like this sort of problem have been raised before, so pardon me if this is just silly.

Currently when in noClassPath mode and with AutoImport, we remove all imports that we cannot resolved (JDTImportBuilder#build()) . Would it be possible to just create Unresolved imports (containing the original string) that could be printed later?

I know that either setting a classpath, or not using autoimport or using the SniperPrettyPrinter more or less solves this kind of issue, but I feel it still could be useful.

But maybe it creates more problem down the line, that I do not see right now.

A simpler option could be at least to log the fact that some import are simply ignored, to inform the user of other solutions.

WDYT?

@monperrus
Copy link
Collaborator

monperrus commented Apr 7, 2019 via email

@monperrus
Copy link
Collaborator

done in #2936

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants